From: Rik van Riel Subject: Re: [PATCH] clear PageError bit in msync & fsync Date: Thu, 11 Nov 2010 11:31:27 -0500 Message-ID: <4CDC1A5F.9050803@redhat.com> References: <20101109114422.3918e7f6@annuminas.surriel.com> <20101109142109.224267d0@corrin.poochiereds.net> <4CD9A209.6070807@redhat.com> <20101109210715.GJ3099@thunk.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit To: "Ted Ts'o" , Jeff Layton , linux-kernel@vger.kernel.org, akpm@linux-foundation.org, esandeen@redhat.com, jmoyer@redhat.com, linux-fsdevel@vger.kernel.org Return-path: In-Reply-To: <20101109210715.GJ3099@thunk.org> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On 11/09/2010 04:07 PM, Ted Ts'o wrote: > Do we guarantee that the application will get EIO at least once? I > thought there were issues where the error bit could get lost if the > page writeback was triggered by sync() run by a third-party > application. Andrew, both the current kernel before and after my patch does not guarantee the behaviour Ted has pointed out is required. Johannes came up with a way to guarantee that - I'll send in a patch for that today. That patch will obsolete the patch I sent before (I don't think you've applied it yet). -- All rights reversed