From: Jeremy Fitzhardinge Subject: Re: [Xen-devel] Re: [PATCH 2/3] xen: add CPU microcode update driver Date: Mon, 15 Nov 2010 17:16:30 -0800 Message-ID: <4CE1DB6E.9080301@goop.org> References: <37a80bdde5957ffa81c2ecdffc4ccc2e874e34cb.1289519130.git.jeremy.fitzhardinge@citrix.com> <20101115155928.GC345@dumpdata.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20101115155928.GC345@dumpdata.com> Sender: linux-kernel-owner@vger.kernel.org To: Konrad Rzeszutek Wilk Cc: the arch/x86 maintainers , Xen-devel , Linux Kernel Mailing List , Jeremy Fitzhardinge , "H. Peter Anvin" List-Id: xen-devel@lists.xenproject.org On 11/15/2010 07:59 AM, Konrad Rzeszutek Wilk wrote: >> +static enum ucode_state xen_request_microcode_user(int cpu, >> + const void __user *buf, size_t size) >> +{ >> + struct ucode_cpu_info *uci = ucode_cpu_info + cpu; >> + struct xen_microcode *uc; >> + enum ucode_state ret; >> + size_t unread; >> + >> + if (cpu != 0) { >> + /* No real firmware for non-zero cpus; just store a >> + placeholder */ >> + size = 0; >> + } >> + >> + if (uci->mc != NULL) { >> + vfree(uci->mc); >> + uci->mc = NULL; >> + } >> + >> + ret = UCODE_ERROR; >> + uc = vmalloc(sizeof(*uc) + size); >> + if (uc == NULL) >> + goto out; >> + >> + uc->len = size; >> + >> + ret = UCODE_NFOUND; >> + >> + /* XXX This sporadically returns uncopied bytes, so we return >> + EFAULT. As far as I can see, the usermode code > ^^^^^ UCODE_NFOUND. >> + (microcode_ctl) isn't doing anything wrong... */ > Is this still valid? Looking at AMD it checks for a magic key and the Intel > just copies without checks. Probably not. J