From: Jeremy Fitzhardinge Subject: Re: [Xen-devel] Re: [PATCH 3/3] xen/microcode: partially enable even for non-privileged kernels Date: Mon, 15 Nov 2010 17:17:20 -0800 Message-ID: <4CE1DBA0.4010302@goop.org> References: <049ad0809c51dedebab0b8e4bfcf58f5f26375b7.1289519130.git.jeremy.fitzhardinge@citrix.com> <20101115160245.GD345@dumpdata.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20101115160245.GD345@dumpdata.com> Sender: linux-kernel-owner@vger.kernel.org To: Konrad Rzeszutek Wilk Cc: the arch/x86 maintainers , Xen-devel , Linux Kernel Mailing List , Jeremy Fitzhardinge , "H. Peter Anvin" List-Id: xen-devel@lists.xenproject.org On 11/15/2010 08:02 AM, Konrad Rzeszutek Wilk wrote: > On Thu, Nov 11, 2010 at 03:58:06PM -0800, Jeremy Fitzhardinge wrote: >> From: Jeremy Fitzhardinge >> >> Don't attempt to load microcode on non-privileged kernels. Kernels > The previous patch had this: > > if (!xen_initial_domain()) > + return NULL; > > which pretty much made non-priviliged kernels not do any micro code loading. > > It sounds like this patch is just to not compile the Xen microcode code > if CONFIG_DOM0 is not enabled? Yeah, I think the patch is a brainfart, and the existing code already did the right thing. J