From: Jes Sorensen Subject: Re: [PATCH v5] virtio-9p: fix build on !CONFIG_UTIMENSAT Date: Wed, 24 Nov 2010 09:01:06 +0100 Message-ID: <4CECC642.8090404@redhat.com> References: <4CEC7A92.3080302@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Cc: "qemu-devel@nongnu.org" , "kvm@vger.kernel.org" , Chris Wright , "M. Mohan Kumar" , "Hao, Xudong" , Blue Swirl , Avi Kivity , Anthony Liguori , Philipp Hahn To: Hidetoshi Seto Return-path: Received: from mx1.redhat.com ([209.132.183.28]:8922 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751376Ab0KXIB0 (ORCPT ); Wed, 24 Nov 2010 03:01:26 -0500 In-Reply-To: <4CEC7A92.3080302@jp.fujitsu.com> Sender: kvm-owner@vger.kernel.org List-ID: On 11/24/10 03:38, Hidetoshi Seto wrote: > This patch introduce a fallback mechanism for old systems that do not > support utimensat(). This fix build failure with following warnings: > > hw/virtio-9p-local.c: In function 'local_utimensat': > hw/virtio-9p-local.c:479: warning: implicit declaration of function 'utimensat' > hw/virtio-9p-local.c:479: warning: nested extern declaration of 'utimensat' > > and: > > hw/virtio-9p.c: In function 'v9fs_setattr_post_chmod': > hw/virtio-9p.c:1410: error: 'UTIME_NOW' undeclared (first use in this function) > hw/virtio-9p.c:1410: error: (Each undeclared identifier is reported only once > hw/virtio-9p.c:1410: error: for each function it appears in.) > hw/virtio-9p.c:1413: error: 'UTIME_OMIT' undeclared (first use in this function) > hw/virtio-9p.c: In function 'v9fs_wstat_post_chmod': > hw/virtio-9p.c:2905: error: 'UTIME_OMIT' undeclared (first use in this function) > > [NOTE: At this time virtio-9p is only user of utimensat(), and is available > only when host is linux and CONFIG_VIRTFS is defined. So there are > no similar warning for win32. Please provide a wrapper for win32 in > oslib-win32.c if new user really requires it.] > > v5: > - Allow fallback on runtime > - Move qemu_utimensat() to oslib-posix.c > - Rebased on latest qemu.git > v4: > - Use tv_now.tv_usec > v3: > - Use better alternative handling for UTIME_NOW/OMIT > - Move qemu_utimensat() to cutils.c > V2: > - Introduce qemu_utimensat() > > Acked-by: Chris Wright > Acked-by: M. Mohan Kumar > Signed-off-by: Hidetoshi Seto > --- > hw/virtio-9p-local.c | 4 ++-- > oslib-posix.c | 48 ++++++++++++++++++++++++++++++++++++++++++++++++ > qemu-os-posix.h | 12 ++++++++++++ > 3 files changed, 62 insertions(+), 2 deletions(-) Hi Hidetoshi, This looks good to me! Acked-by: Jes Sorensen Cheers, Jes