From: Avi Kivity Subject: Re: [PATCH] Don't spam trace report about missing fields Date: Mon, 29 Nov 2010 19:22:05 +0200 Message-ID: <4CF3E13D.7040204@redhat.com> References: <1291047601-13879-1-git-send-email-avi@redhat.com> <1291048005.30543.731.camel@gandalf.stny.rr.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-users@vger.kernel.org To: Steven Rostedt Return-path: In-Reply-To: <1291048005.30543.731.camel@gandalf.stny.rr.com> Sender: linux-trace-users-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 11/29/2010 06:26 PM, Steven Rostedt wrote: > On Mon, 2010-11-29 at 18:20 +0200, Avi Kivity wrote: > > Instead of spamming the output with complaints about missing fields, simply > > return an error to the caller, which can print something out or do something > > more intelligent about them. > > > > Fixes kvm plugin tracing older kernels. > > Hmm, what about just passing in err=0? I was just patching the printk out it mindlessly. Will send a new patch. -- error compiling committee.c: too many arguments to function