Message-ID: <4CFA3D34.2030300@...68...> Date: Sat, 04 Dec 2010 14:08:04 +0100 From: Matthias Andree MIME-Version: 1.0 References: <1291467757-7115-1-git-send-email-matthias.andree@...68...> In-Reply-To: <1291467757-7115-1-git-send-email-matthias.andree@...68...> Subject: Re: [Openvpn-devel] [PATCH] Remove excess semicolon (invalid C99). List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit To: openvpn-devel@lists.sourceforge.net Am 04.12.2010 14:02, schrieb Matthias Andree: > Signed-off-by: Matthias Andree > --- > misc.h | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) This applies to the beta2.2 branch and affects this code section: 138 139 static inline bool 140 openvpn_run_script (const struct argv *a, const struct env_set *es, const unsigned int flags, const char *hook) 141 { 142 char msg[256]; 143 144 openvpn_snprintf(msg, sizeof(msg), "WARNING: Failed running command (%s)", hook); 145 return openvpn_execve_check(a, es, flags | S_SCRIPT, msg); 146 }; 147 Evidently this is a function definition and hence not to be followed by a semicolon. Most compilers will accept it, but try gcc -Wall -Wextra -pedantic -std=c99 and see what you get :) -- Matthias Andree