From: Ben Greear Date: Mon, 06 Dec 2010 21:36:24 -0800 Subject: [ath9k-devel] [PATCH] ath9k: Check for NULL sta in ath_tx_start In-Reply-To: References: <1291698829-22765-1-git-send-email-greearb@candelatech.com> Message-ID: <4CFDC7D8.3080100@candelatech.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ath9k-devel@lists.ath9k.org On 12/06/2010 09:21 PM, Luis R. Rodriguez wrote: > On Mon, Dec 6, 2010 at 9:13 PM, wrote: >> From: Ben Greear >> >> It can be NULL according to docs, and logging showed it >> to be NULL in practice. >> >> Signed-off-by: Ben Greear > > Does this fix an oops? If so can you explain and provide the trace and > resubmit and cc stable in the commit log? I think it fixes the TID corruption I posted about earlier. It seems so obvious though, that I'm curious why no one else sees problems, and why I didn't see more crashes in my setup. (The paprd code appears to send with null STA, for instance, and my printks showed lots of NULL stas in my 16-sta test setup, though I don't think I'm using the paprd code path.) I'll test some more and re-post tomorrow if all goes well. Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com