From: Wei Huang Subject: [PATCH 1/2] xsave: extend xsave/xrstor support to all (64) features Date: Wed, 22 Dec 2010 14:58:09 -0600 Message-ID: <4D126661.2050806@amd.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------080201000706060500050702" Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "'xen-devel@lists.xensource.com'" , keir@xen.org, "Shan, Haitao" List-Id: xen-devel@lists.xenproject.org --------------080201000706060500050702 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit This patch fixes 64bit xsave_feature support for set_xcr0(). It also turns on bit 62 for AMD lightweight profiling (LWP). The spec of LWP is available at http://developer.amd.com/cpu/lwp/Pages/default.aspx. Signed-off-by: Wei Huang --------------080201000706060500050702 Content-Type: text/plain; name="xsave_extension_patch_1.txt" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="xsave_extension_patch_1.txt" Content-Description: xsave_extension_patch_1.txt exporting patch: # HG changeset patch # User Wei Huang # Date 1293045835 21600 # Branch lwp2 # Node ID f963fa2d256d6af97e8b079191657bf55555e416 # Parent 77e98097afc63c774b329343788f71495a7e5934 Add LWP (bit 62) to XSTATE_MASK definition diff -r 77e98097afc6 -r f963fa2d256d xen/arch/x86/i387.c --- a/xen/arch/x86/i387.c Wed Dec 22 12:18:18 2010 -0600 +++ b/xen/arch/x86/i387.c Wed Dec 22 13:23:55 2010 -0600 @@ -187,7 +187,7 @@ * Set CR4_OSXSAVE and run "cpuid" to get xsave_cntxt_size. */ set_in_cr4(X86_CR4_OSXSAVE); - set_xcr0(eax & XCNTXT_MASK); + set_xcr0((((u64)edx << 32) | eax) & XCNTXT_MASK); cpuid_count(XSTATE_CPUID, 0, &eax, &ebx, &ecx, &edx); if ( cpu == 0 ) diff -r 77e98097afc6 -r f963fa2d256d xen/include/asm-x86/i387.h --- a/xen/include/asm-x86/i387.h Wed Dec 22 12:18:18 2010 -0600 +++ b/xen/include/asm-x86/i387.h Wed Dec 22 13:23:55 2010 -0600 @@ -22,11 +22,12 @@ int xsave_alloc_save_area(struct vcpu *v); void xsave_free_save_area(struct vcpu *v); -#define XSTATE_FP (1 << 0) -#define XSTATE_SSE (1 << 1) -#define XSTATE_YMM (1 << 2) +#define XSTATE_FP (1ULL << 0) +#define XSTATE_SSE (1ULL << 1) +#define XSTATE_YMM (1ULL << 2) +#define XSTATE_LWP (1ULL << 62) /* AMD lightweight profiling */ #define XSTATE_FP_SSE (XSTATE_FP | XSTATE_SSE) -#define XCNTXT_MASK (XSTATE_FP | XSTATE_SSE | XSTATE_YMM) +#define XCNTXT_MASK (XSTATE_FP | XSTATE_SSE | XSTATE_YMM | XSTATE_LWP) #define XSTATE_YMM_OFFSET (512 + 64) #define XSTATE_YMM_SIZE 256 #define XSAVEOPT (1 << 0) --------------080201000706060500050702 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --------------080201000706060500050702--