From: Joel Soete Subject: Re: Help: major pppoe regression since 2.6.35 (panic on first ppp conection)? Date: Thu, 23 Dec 2010 11:02:55 +0000 Message-ID: <4D132C5F.8090404@scarlet.be> References: <20101222110021.GA8985@ff.dom.local> <4D122093.6060900@scarlet.be> <1293035100.3027.247.camel@edumazet-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Jarek Poplawski , Andrew Morton , Linux Kernel , netdev@vger.kernel.org To: Eric Dumazet Return-path: In-Reply-To: <1293035100.3027.247.camel@edumazet-laptop> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Hello Eric, On 12/22/2010 04:25 PM, Eric Dumazet wrote: [snip] > > Something overwrites nr_frags in skb_shinfo(skb) > > As skb_shinfo follows head portion of an skb, something overflows skb > head > > Please try adding some room like in following patch ? > > diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h > index e6ba898..adf2834 100644 > --- a/include/linux/skbuff.h > +++ b/include/linux/skbuff.h > @@ -187,6 +187,7 @@ enum { > * the end of the header data, ie. at skb->end. > */ > struct skb_shared_info { > + char filler[64]; > unsigned short nr_frags; > unsigned short gso_size; > /* Warning: this field is not always filled in (UFO)! */ > Sorry for delay but I have good news, I am sending this answer from: $ uname -a Linux sidh2 2.6.37-rc7-amd64-t1 #1 SMP Thu Dec 23 10:30:27 GMT 2010 x86_64 GNU/Linux with your tips ;<) (without kernel had already died) That said how can find stuff overflowing skb head? (all I say, is that this issue started with 2.6.34-git6???) Thanks a lot, J.