From: Jan Kiszka Subject: Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state Date: Tue, 11 Jan 2011 18:13:44 +0100 Message-ID: <4D2C8FC8.2090506@web.de> References: <4D2B6CB5.9050602@codemonkey.ws> <4D2B74D8.4080309@web.de> <4D2B8662.9060909@web.de> <4D2C1A96.9010109@redhat.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig0C8A6F5B81D8AFBD934A0EE6" Cc: Anthony Liguori , Marcelo Tosatti , Anthony Liguori , Glauber Costa , qemu-devel@nongnu.org, kvm@vger.kernel.org To: Gerd Hoffmann Return-path: Received: from fmmailgate02.web.de ([217.72.192.227]:39350 "EHLO fmmailgate02.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932422Ab1AKRNw (ORCPT ); Tue, 11 Jan 2011 12:13:52 -0500 In-Reply-To: <4D2C1A96.9010109@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig0C8A6F5B81D8AFBD934A0EE6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Am 11.01.2011 09:53, Gerd Hoffmann wrote: > Hi, >=20 >> Actually, there is already a channel to pass pointers to qdev devices:= >> the pointer property hack. I'm not sure we should contribute to its us= er >> base or take the chance for a cleanup, but we are not alone with this >> requirement. Point below remains valid, though. >=20 > It is considered bad/hackish style as you can't create that kind of > devices using the -device command line switch (or from a machine > description config file some day in the future). That kind of instantiation wouldn't be possible for device models that require someone actively passing kvm_state to them... > So we should not add > more uses of this, especially not in patches which are supposed to > cleanup things ;) You won't see me disagree. Jan --------------enig0C8A6F5B81D8AFBD934A0EE6 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/ iEYEARECAAYFAk0sj8sACgkQitSsb3rl5xThmwCgnwh6l41QkG8HEy1/FeHZGFk1 kC8An2d0UBxCZqqtfTEIxDBZWwfAmNtO =MwgY -----END PGP SIGNATURE----- --------------enig0C8A6F5B81D8AFBD934A0EE6--