From: David Daney <ddaney@caviumnetworks.com>
Subject: Re: [PATCH 01/10] Add yaffs2 file system: Allocation, block handling
 and bitmapping code
Date: Wed, 19 Jan 2011 12:37:46 -0800
Message-ID: <4D374B9A.3040002@caviumnetworks.com>
References: <1294974369-31647-1-git-send-email-cdhmanning@gmail.com> <1294974369-31647-2-git-send-email-cdhmanning@gmail.com> <4D3748C5.4070600@bluewatersys.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Charles Manning <cdhmanning@gmail.com>,
	linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	akpm@linux-foundation.org
To: Ryan Mallon <ryan@bluewatersys.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mail3.caviumnetworks.com ([12.108.191.235]:7936 "EHLO
	mail3.caviumnetworks.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752790Ab1ASUhw (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Wed, 19 Jan 2011 15:37:52 -0500
In-Reply-To: <4D3748C5.4070600@bluewatersys.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On 01/19/2011 12:25 PM, Ryan Mallon wrote:
> On 01/14/2011 04:06 PM, Charles Manning wrote:
[...]
>> +	if (!allocator) {
>> +		YBUG();
>> +		return;
>> +	}
>
> You don't need this bug, the dereference of allocator below will oops
> with all the same information as bug.
>

Is that true for nommu systems too?

David Daney