From: Juergen Gross Subject: Re: [PATCH]: xl: fix broken cpupool-numa-split Date: Fri, 28 Jan 2011 07:26:17 +0100 Message-ID: <4D426189.1030001@ts.fujitsu.com> References: <4D41E547.5000902@amd.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------060501030001000706040608" Return-path: In-Reply-To: <4D41E547.5000902@amd.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Andre Przywara Cc: "xen-devel@lists.xensource.com" , Ian Jackson List-Id: xen-devel@lists.xenproject.org This is a multi-part message in MIME format. --------------060501030001000706040608 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit On 01/27/11 22:36, Andre Przywara wrote: > Hi, > > the implementation of xl cpupool-numa-split is broken. It basically > deals with only one poolid, but there are two to consider: the one from > the original root CPUpool, the other from the newly created one. Uhh, silly copy and paste error! I think it happened when I introduced libxl_cpupool_cpuadd_node()... The correction is much easier. The root poolid is always 0. See attached patch. Juergen -- Juergen Gross Principal Developer Operating Systems TSP ES&S SWE OS6 Telephone: +49 (0) 89 3222 2967 Fujitsu Technology Solutions e-mail: juergen.gross@ts.fujitsu.com Domagkstr. 28 Internet: ts.fujitsu.com D-80807 Muenchen Company details: ts.fujitsu.com/imprint.html --------------060501030001000706040608 Content-Type: text/x-patch; name="cpupool-numa-split-corr.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="cpupool-numa-split-corr.patch" Correct copy&paste error: add node to the new pool instead of pool 0 Signed-off-by: juergen.gross@ts.fujitsu.com diff -r 9dca60d88c63 tools/libxl/xl_cmdimpl.c --- a/tools/libxl/xl_cmdimpl.c Tue Jan 25 14:06:52 2011 +0000 +++ b/tools/libxl/xl_cmdimpl.c Fri Jan 28 07:21:53 2011 +0100 @@ -5806,7 +5806,7 @@ int main_cpupoolnumasplit(int argc, char goto out; } - ret = -libxl_cpupool_cpuadd_node(&ctx, 0, node, &n); + ret = -libxl_cpupool_cpuadd_node(&ctx, poolid, node, &n); if (ret) { fprintf(stderr, "error on adding cpus to cpupool\n"); goto out; --------------060501030001000706040608 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --------------060501030001000706040608--