Received: from [140.186.70.92] (port=51904 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PpX5a-0001yh-8u for qemu-devel@nongnu.org; Tue, 15 Feb 2011 21:25:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PpX5W-0004Vk-I2 for qemu-devel@nongnu.org; Tue, 15 Feb 2011 21:25:56 -0500 Received: from [222.73.24.84] (port=60568 helo=song.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PpX5W-0004VT-63 for qemu-devel@nongnu.org; Tue, 15 Feb 2011 21:25:54 -0500 Received: from tang.cn.fujitsu.com (tang.cn.fujitsu.com [10.167.250.3]) by song.cn.fujitsu.com (Postfix) with ESMTP id 2315F170116 for ; Wed, 16 Feb 2011 10:25:45 +0800 (CST) Received: from mailserver.fnst.cn.fujitus.com (tang.cn.fujitsu.com [127.0.0.1]) by tang.cn.fujitsu.com (8.14.3/8.13.1) with ESMTP id p1G2K6rf007354 for ; Wed, 16 Feb 2011 10:20:06 +0800 Message-ID: <4D5B353E.2060500@cn.fujitsu.com> Date: Wed, 16 Feb 2011 10:23:58 +0800 From: Wen Congyang MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=ISO-8859-1 Subject: [Qemu-devel] [PATCH] fix memory leak when we uninit a drive List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel We alloc memory for dinfo->id, so we should free it in the function drive_uninit(). Signed-off-by: Wen Congyang --- blockdev.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/blockdev.c b/blockdev.c index ecfadc1..1333a4e 100644 --- a/blockdev.c +++ b/blockdev.c @@ -183,6 +183,8 @@ static void drive_uninit(DriveInfo *dinfo) qemu_opts_del(dinfo->opts); bdrv_delete(dinfo->bdrv); QTAILQ_REMOVE(&drives, dinfo, next); + if (dinfo->id) + qemu_free(dinfo->id); qemu_free(dinfo); } -- 1.7.1