From: Zachary Amsden Subject: Re: [PATCH] add missing guest clock update removed by e48672fa25e879f7ae21785c7efd187738139593 Date: Wed, 09 Mar 2011 16:29:45 -0500 Message-ID: <4D77F149.8020906@redhat.com> References: <20110307101827.GA1762@pcnci.linuxbox.cz> <4D768A62.3050903@redhat.com> <20110309193003.GB1762@pcnci.linuxbox.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: KVM list , Linux kernel list , nikola.ciprich@linuxbox.cz, Avi Kivity , Glauber Costa To: Nikola Ciprich Return-path: In-Reply-To: <20110309193003.GB1762@pcnci.linuxbox.cz> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 03/09/2011 02:30 PM, Nikola Ciprich wrote: >> Can you try moving the kvm_make_request() inside the if conditional and >> see if it that also fixes it? >> > yes, changing to: > if (unlikely(vcpu->cpu != cpu) || check_tsc_unstable()) { > kvm_make_request(KVM_REQ_CLOCK_UPDATE, vcpu); > /* Make sure TSC doesn't go backwards */ > s64 tsc_delta = !vcpu->arch.last_host_tsc ? 0 : > > is also OK. > > what about changing: > if (check_tsc_unstable()) { > kvm_x86_ops->adjust_tsc_offset(vcpu, -tsc_delta); > vcpu->arch.tsc_catchup = 1; > kvm_make_request(KVM_REQ_CLOCK_UPDATE, vcpu); > } > > to: > > if (check_tsc_unstable()) { > kvm_x86_ops->adjust_tsc_offset(vcpu, -tsc_delta); > vcpu->arch.tsc_catchup = 1; > } > kvm_make_request(KVM_REQ_CLOCK_UPDATE, vcpu); > > this fixes thinks for me as well.. > n. > ? > Can you send a patch which does that? I think this is the correct fix. Thanks, Zach