From: Matthew Fioravante Subject: Re: [PATCH 3/12] VTPM mini-os: Add ioread() and iowrite() functions to mini-os Date: Mon, 14 Mar 2011 13:10:54 -0400 Message-ID: <4D7E4C1E.1030801@jhuapl.edu> References: <4D7AA468.7000204@jhuapl.edu> <20110312002914.GD4922@const.famille.thibault.fr> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2140629552==" Return-path: In-Reply-To: <20110312002914.GD4922@const.famille.thibault.fr> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Samuel Thibault Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org This is a cryptographically signed message in MIME format. --===============2140629552== Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha1; boundary="------------ms020308050102020604060704" This is a cryptographically signed message in MIME format. --------------ms020308050102020604060704 Content-Type: multipart/mixed; boundary="------------040303060405000504070909" This is a multi-part message in MIME format. --------------040303060405000504070909 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Yeah your right, sorry about that! Heres a patch that applies on top of=20 the previous one to add volatile. Signed off by: Matthew Fioravante On 03/11/2011 07:29 PM, Samuel Thibault wrote: > Matthew Fioravante, le Fri 11 Mar 2011 17:38:32 -0500, a =E9crit : >> Mini-os currently doesn't have very many facilities for reading and >> writing to hardware io memory. This patch addes a new header file >> iorw.h which when included gives access to >> the ioread8(), iread32(), iowrite8(), iowrite32() family of functions.= > >> +void iowrite8(void* addr, uint8_t val) >> +{ >> + *((uint8_t*)addr) =3D val; >> +} >> +void iowrite32(void* addr, uint32_t val) >> +{ >> + *((uint32_t*)addr) =3D val; >> +} > Don't you need a volatile qualifier on the cast pointer to not let the > compiler optimize it away? > > Samuel --------------040303060405000504070909 Content-Type: text/plain; name="3-minios-iorw.patch2" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="3-minios-iorw.patch2" diff -r 01c0d5a14e11 extras/mini-os/arch/ia64/iorw.c --- a/extras/mini-os/arch/ia64/iorw.c Mon Mar 14 12:51:22 2011 -0400 +++ b/extras/mini-os/arch/ia64/iorw.c Mon Mar 14 13:07:14 2011 -0400 @@ -1,21 +1,21 @@ #include #include =20 -void iowrite8(void* addr, uint8_t val) +void iowrite8(volatile void* addr, uint8_t val) { printk("iorw not implemented!!\n"); } -void iowrite32(void* addr, uint32_t val) +void iowrite32(volatile void* addr, uint32_t val) { printk("iorw not implemented!!\n"); } =20 -uint8_t ioread8(void* addr) +uint8_t ioread8(volatile void* addr) { printk("iorw not implemented!!\n"); return 0; } -uint32_t ioread32(void* addr) +uint32_t ioread32(volatile void* addr) { printk("iorw not implemented!!\n"); return 0; diff -r 01c0d5a14e11 extras/mini-os/arch/x86/iorw.c --- a/extras/mini-os/arch/x86/iorw.c Mon Mar 14 12:51:22 2011 -0400 +++ b/extras/mini-os/arch/x86/iorw.c Mon Mar 14 13:07:14 2011 -0400 @@ -1,20 +1,20 @@ #include =20 -void iowrite8(void* addr, uint8_t val) +void iowrite8(volatile void* addr, uint8_t val) { - *((uint8_t*)addr) =3D val; + *((volatile uint8_t*)addr) =3D val; } -void iowrite32(void* addr, uint32_t val) +void iowrite32(volatile void* addr, uint32_t val) { - *((uint32_t*)addr) =3D val; + *((volatile uint32_t*)addr) =3D val; } =20 -uint8_t ioread8(void* addr) +uint8_t ioread8(volatile void* addr) { - return *((uint8_t*) addr); + return *((volatile uint8_t*) addr); } -uint32_t ioread32(void* addr) +uint32_t ioread32(volatile void* addr) { - return *((uint32_t*) addr); + return *((volatile uint32_t*) addr); } =20 diff -r 01c0d5a14e11 extras/mini-os/include/iorw.h --- a/extras/mini-os/include/iorw.h Mon Mar 14 12:51:22 2011 -0400 +++ b/extras/mini-os/include/iorw.h Mon Mar 14 13:07:14 2011 -0400 @@ -3,10 +3,10 @@ =20 #include =20 -void iowrite8(void* addr, uint8_t val); -void iowrite32(void* addr, uint32_t val); +void iowrite8(volatile void* addr, uint8_t val); +void iowrite32(volatile void* addr, uint32_t val); =20 -uint8_t ioread8(void* addr); -uint32_t ioread32(void* addr); +uint8_t ioread8(volatile void* addr); +uint32_t ioread32(volatile void* addr); =20 #endif --------------040303060405000504070909-- --------------ms020308050102020604060704 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIHZzCC A5kwggMCoAMCAQICBD/xkcEwDQYJKoZIhvcNAQEFBQAwLzELMAkGA1UEBhMCVVMxDzANBgNV BAoTBkpIVUFQTDEPMA0GA1UECxMGQklTRENBMB4XDTA5MDcxNzE1MDgwOVoXDTEyMDcxNzE1 MzgwOVowZjELMAkGA1UEBhMCVVMxDzANBgNVBAoTBkpIVUFQTDEPMA0GA1UECxMGUGVvcGxl MTUwFgYDVQQLEw9WUE5Hcm91cC1CSVNEQ0EwGwYDVQQDExRNYXR0aGV3IEUgRmlvcmF2YW50 ZTCBnzANBgkqhkiG9w0BAQEFAAOBjQAwgYkCgYEAyzeGk9zPA33fsB3uvk/Izs9GGHCpHI8b zXdBIVg6++S+jK53PoaWgmtSLr/c732ea1zPR6ACymwAWON+U5rB+VJAUZ4l/p0T3LZjE1Kq nbQJ+pgb+WAmBtdrxrtky61E9HD8dO70x37+ejhunpF9OuSU5MnOPmMx6ranvahUsOsCAwEA AaOCAYkwggGFMAsGA1UdDwQEAwIFIDAbBg0rBgEEAbMlCwMBAQEBBAoWCGZpb3JhbWUxMBsG DSsGAQQBsyULAwEBAQIEChIIMDAxMDQyNjEwWAYJYIZIAYb6ax4BBEsMSVRoZSBwcml2YXRl IGtleSBjb3JyZXNwb25kaW5nIHRvIHRoaXMgY2VydGlmaWNhdGUgbWF5IGhhdmUgYmVlbiBl eHBvcnRlZC4wKAYDVR0RBCEwH4EdTWF0dGhldy5GaW9yYXZhbnRlQGpodWFwbC5lZHUwUgYD VR0fBEswSTBHoEWgQ6RBMD8xCzAJBgNVBAYTAlVTMQ8wDQYDVQQKEwZKSFVBUEwxDzANBgNV BAsTBkJJU0RDQTEOMAwGA1UEAxMFQ1JMNDkwHwYDVR0jBBgwFoAUCDUpmxH52EU2CyWmF2EJ MB1yqeswHQYDVR0OBBYEFO3ziReJlElP3ilaLQ5gwsg0RlgoMAkGA1UdEwQCMAAwGQYJKoZI hvZ9B0EABAwwChsEVjcuMQMCBLAwDQYJKoZIhvcNAQEFBQADgYEAMOY3Zf6gx3gv/fDd11cz h2Daj+8NExx/2Le3c88gfDVhPVgVX5S52EjeFbK5yVP0Xlm82vRADO47dTA2PKbpp50rJcAZ rl5bg5tQ/WbLAaRITCtOJWVVKXD9V7X2o3Z/IM2op3hb4mmDXSDS+Hzn0Jd2mAXl4iHPfI0p XlXqA9QwggPGMIIDL6ADAgECAgQ/8cn9MA0GCSqGSIb3DQEBBQUAMC8xCzAJBgNVBAYTAlVT MQ8wDQYDVQQKEwZKSFVBUEwxDzANBgNVBAsTBkJJU0RDQTAeFw0xMDA2MTExODIyMDZaFw0x MzA2MTExODUyMDZaMGYxCzAJBgNVBAYTAlVTMQ8wDQYDVQQKEwZKSFVBUEwxDzANBgNVBAsT BlBlb3BsZTE1MBYGA1UECxMPVlBOR3JvdXAtQklTRENBMBsGA1UEAxMUTWF0dGhldyBFIEZp b3JhdmFudGUwgZ8wDQYJKoZIhvcNAQEBBQADgY0AMIGJAoGBAJ6W8FUj+qNTW+ZXFu3Xd8k6 PYgSXYu6s+JwDTjBTyuyTsuZ6SjdYoqLrJdvFP7HFCREueYD8AFmCSt7lckALAOGnYAyouQ6 A9VBw0BMKW2O4hyyXqtDT6+AamDapwhT2xOhwvM0ia6+Kip/oFVEE9/UiBanYiDycGS/BWE0 UP87AgMBAAGjggG2MIIBsjALBgNVHQ8EBAMCB4AwKwYDVR0QBCQwIoAPMjAxMDA2MTExODIy MDZagQ8yMDEyMDcxNzIyNTIwNlowGwYNKwYBBAGzJQsDAQEBAQQKFghmaW9yYW1lMTAbBg0r BgEEAbMlCwMBAQECBAoSCDAwMTA0MjYxMFgGCWCGSAGG+mseAQRLDElUaGUgcHJpdmF0ZSBr ZXkgY29ycmVzcG9uZGluZyB0byB0aGlzIGNlcnRpZmljYXRlIG1heSBoYXZlIGJlZW4gZXhw b3J0ZWQuMCgGA1UdEQQhMB+BHU1hdHRoZXcuRmlvcmF2YW50ZUBqaHVhcGwuZWR1MFIGA1Ud HwRLMEkwR6BFoEOkQTA/MQswCQYDVQQGEwJVUzEPMA0GA1UEChMGSkhVQVBMMQ8wDQYDVQQL EwZCSVNEQ0ExDjAMBgNVBAMTBUNSTDU2MB8GA1UdIwQYMBaAFAg1KZsR+dhFNgslphdhCTAd cqnrMB0GA1UdDgQWBBTui2MYOq/cB2fs3ULQR59XWf2EzTAJBgNVHRMEAjAAMBkGCSqGSIb2 fQdBAAQMMAobBFY3LjEDAgSwMA0GCSqGSIb3DQEBBQUAA4GBACTvR0IeGDQoVS87maiuQESQ EQ/CaLoxmX3aO+arr4No1xUHtrBI7y58SWYJv6b/H3WWpKuPAlsI2ByrryKe7A40xLEH6Psu 0qTfzdjbyVlOUqnytVYGLTS0UaBiVAeUNWmfg4PeYN5Kqcn6VDCEiS/CClS7SVXzeH4IBVVG GfcMMYICMTCCAi0CAQEwNzAvMQswCQYDVQQGEwJVUzEPMA0GA1UEChMGSkhVQVBMMQ8wDQYD VQQLEwZCSVNEQ0ECBD/xyf0wCQYFKw4DAhoFAKCCAVAwGAYJKoZIhvcNAQkDMQsGCSqGSIb3 DQEHATAcBgkqhkiG9w0BCQUxDxcNMTEwMzE0MTcxMDU0WjAjBgkqhkiG9w0BCQQxFgQUYS3K SYG/JszfOGTXYBN/447AdBowRgYJKwYBBAGCNxAEMTkwNzAvMQswCQYDVQQGEwJVUzEPMA0G A1UEChMGSkhVQVBMMQ8wDQYDVQQLEwZCSVNEQ0ECBD/xkcEwSAYLKoZIhvcNAQkQAgsxOaA3 MC8xCzAJBgNVBAYTAlVTMQ8wDQYDVQQKEwZKSFVBUEwxDzANBgNVBAsTBkJJU0RDQQIEP/GR wTBfBgkqhkiG9w0BCQ8xUjBQMAsGCWCGSAFlAwQBAjAKBggqhkiG9w0DBzAOBggqhkiG9w0D AgICAIAwDQYIKoZIhvcNAwICAUAwBwYFKw4DAgcwDQYIKoZIhvcNAwICASgwDQYJKoZIhvcN AQEBBQAEgYCLzCCI9Srm7bhyEaRQtnjBzhnqRX06jjwRm0M+XOkf38IXMNV9VIKLRWcVq3V4 mZSI7LgN6s+Z+BHc4qmANB5mO/EyTCLdj0JWDCgq8krMFZvL2t3c2B1qvBddYS1VM0AhgOXH 5jVbFBvpEX8hIyOujjFHDBfDrL+vvvcpgYe08QAAAAAAAA== --------------ms020308050102020604060704-- --===============2140629552== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --===============2140629552==--