From: Jeremy Fitzhardinge Subject: Re: [Xen-devel] Re: [RFC PATCH V4 4/5] cpuidle: driver for xen Date: Fri, 25 Mar 2011 14:38:58 +0000 Message-ID: <4D8CA902.7090907@goop.org> References: <20110322123208.28725.30945.stgit@tringupt.in.ibm.com> <20110322123324.28725.3131.stgit@tringupt.in.ibm.com> <20110322145054.GB26952@dumpdata.com> <4D89C40B.4020809@linux.vnet.ibm.com> <20110324120522.GB29294@dumpdata.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20110324120522.GB29294@dumpdata.com> Sender: linux-kernel-owner@vger.kernel.org To: Konrad Rzeszutek Wilk Cc: Len Brown , venki@google.com, ak@linux.intel.com, suresh.b.siddha@intel.com, sfr@canb.auug.org.au, peterz@infradead.org, benh@kernel.crashing.org, linux-kernel@vger.kernel.org, xen-devel@lists.xensource.com, arjan@linux.intel.com, Trinabh Gupta List-Id: xen-devel@lists.xenproject.org On 03/24/2011 12:05 PM, Konrad Rzeszutek Wilk wrote: > On Thu, Mar 24, 2011 at 03:18:14AM -0400, Len Brown wrote: >> Is a CONFIG_XEN kernel supposed to use just HLT in idle? > For right now.. For always, I should think. >> xen_arch_setup() does this: >> >> pm_idle = default_idle; >> boot_option_idle_override = IDLE_HALT; >> >> which has that effect. I guess this makes sense b/c the >> CONFIG_XEN kernel is Dom0 and the real C-sates are done >> by the hypervisor? > Correct. There are some patches that make the C-states > be visible in the Linux kernel, but that hasn't been ported > over yet. All we need is for the idle CPU to block in the hypervisor; a plain "hlt" is always going to be sufficient (which is overridden as a pvop into a sched_idle hypercall). Xen will choose an appropriate power state for the physical cpus depending on the overall busyness of the system (which any individual virtual machine can't determine). J