From: Paulius Zaleckas <paulius.zaleckas@gmail.com>
Date: Wed, 20 Apr 2011 11:20:41 +0300
Subject: [ath9k-devel] [PATCH 2/5] ath9k_htc: Fix AMPDU subframe handling
In-Reply-To: <19886.28554.581823.283614@gargle.gargle.HOWL>
References: <19886.28554.581823.283614@gargle.gargle.HOWL>
Message-ID: <4DAE9759.9020005@gmail.com>
List-Id: <ath9k-devel.lists.ath9k.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: ath9k-devel@lists.ath9k.org

On 04/20/2011 08:30 AM, Sujith wrote:
> From: Sujith Manoharan<Sujith.Manoharan@atheros.com>
>
> * Register the driver's maximum ampdu subframe limit to mac80211.
> * Cleanup the target capabilities structure and fix an endian issue.
> * Fix BTCOEX by sending a command to the target when the BT priority
>    changes.
> * Bump the required firmware version to 1.1
>
> Signed-off-by: Sujith Manoharan<Sujith.Manoharan@atheros.com>

[...]

> +	/*
> +	 * Check if the available FW matches the driver's
> +	 * required version.
> +	 */
> +	if (priv->fw_version_major<  MAJOR_VERSION_REQ ||
> +	    priv->fw_version_minor<  MINOR_VERSION_REQ) {

Wrong version check logic. Version 2.0 will fail this 1.1 check, because 
of minor version number.
Should be something like:
if (priv->fw_version_major < MAJOR_VERSION_REQ ||
     (priv->fw_version_major == MAJOR_VERSION_REQ &&
      priv->fw_version_minor < MINOR_VERSION_REQ))

> +		dev_err(priv->dev, "ath9k_htc: Please upgrade to FW version %d.%d\n",
> +			MAJOR_VERSION_REQ, MINOR_VERSION_REQ);
> +		return -EINVAL;
> +	}
> +
>   	return 0;
>   }