From: Sergei Shtylyov Subject: Re: [PATCH V2 5/5] USB: OTG: msm: Add PHY suspend support for MSM8960 Date: Mon, 02 May 2011 16:22:45 +0400 Message-ID: <4DBEA215.5080806@ru.mvista.com> References: <1303977693-18389-1-git-send-email-pkondeti@codeaurora.org> <1304318192-24374-1-git-send-email-pkondeti@codeaurora.org> <1304318192-24374-6-git-send-email-pkondeti@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ww0-f42.google.com ([74.125.82.42]:40473 "EHLO mail-ww0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754250Ab1EBMY0 (ORCPT ); Mon, 2 May 2011 08:24:26 -0400 In-Reply-To: <1304318192-24374-6-git-send-email-pkondeti@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Pavankumar Kondeti Cc: greg@kroah.com, linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org, davidb@codeaurora.org, sshtylyov@mvista.com Hello. On 02-05-2011 10:36, Pavankumar Kondeti wrote: > Signed-off-by: Pavankumar Kondeti [...] > diff --git a/drivers/usb/otg/msm_otg.c b/drivers/usb/otg/msm_otg.c > index 66a1b7c..52853fd 100644 > --- a/drivers/usb/otg/msm_otg.c > +++ b/drivers/usb/otg/msm_otg.c > @@ -163,6 +163,32 @@ put_3p3: > return rc; > } > > +#ifdef CONFIG_PM_SLEEP > +#define USB_PHY_SUSP_DIG_VOL 500000 > +static int msm_hsusb_config_vddcx(int high) > +{ > + int max_vol = USB_PHY_VDD_DIG_VOL_MAX; > + int min_vol; > + int ret; > + > + if (high) > + min_vol = USB_PHY_VDD_DIG_VOL_MIN; > + else > + min_vol = USB_PHY_SUSP_DIG_VOL; > + > + ret = regulator_set_voltage(hsusb_vddcx, min_vol, max_vol); > + if (ret) { > + pr_err("%s: unable to set the voltage for regulator" You missed space after "regulator"... > + "HSUSB_VDDCX\n", __func__); > + return ret; > + } > + [...] WBR, Sergei