From: Jan Kiszka <jan.kiszka@siemens.com>
Subject: Re: [PATCH v2] Import Linux headers for KVM and vhost
Date: Wed, 04 May 2011 12:28:32 +0200
Message-ID: <4DC12A50.1000800@siemens.com>
References: <4DC00BB1.7000008@siemens.com>	<4DC031CC.1040902@siemens.com>
	<BANLkTinr-G36+zy=0B1U6D-4-6hnn3GRmg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: Anthony Liguori <aliguori@us.ibm.com>, kvm <kvm@vger.kernel.org>,
	Marcelo Tosatti <mtosatti@redhat.com>, Alexander Graf <agraf@suse.de>,
	qemu-devel <qemu-devel@nongnu.org>, Avi Kivity <avi@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Return-path: <qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org>
In-Reply-To: <BANLkTinr-G36+zy=0B1U6D-4-6hnn3GRmg@mail.gmail.com>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: </archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org
Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org
List-Id: kvm.vger.kernel.org

On 2011-05-03 22:22, Peter Maydell wrote:
> On 3 May 2011 17:48, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>> +++ b/scripts/update-linux-headers.sh
>> @@ -0,0 +1,47 @@
>> +#!/bin/sh
> 
> No -e ?
> 
>> +rm -rf $output/include/linux/*
> 
> Given that updating the kernel headers will blow away large
> subsets of include/ like this, maybe we should use a less generic
> name than "include", so it's clear that it's just a set of
> automatically maintained and updated files, rather than
> a good place to put random QEMU header files?
> 
> kernel-headers/ seems like an obvious choice.
> 
> Is it worth having a README in the directory saying "don't
> edit these, they are copies of the kernel headers, they can
> be updated with <whatever>", or is that unnecessary?
> 

No, these suggestion all make sense. I've incorporated them.

Thanks,
Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux