From: Avi Kivity Subject: Re: [PATCH x86 kvm] Fix register corruption in pvclock_scale_delta Date: Wed, 22 Jun 2011 12:39:17 +0300 Message-ID: <4E01B845.9010102@redhat.com> References: <4DF97D6C.2080900@redhat.com> <4DFDEF2A.7050307@redhat.com> <1308735302.6920.172.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Zachary Amsden , kvm , Linux-kernel , Ulrich Obergfell To: Ian Campbell , Marcelo Tosatti Return-path: In-Reply-To: <1308735302.6920.172.camel@zakaz.uk.xensource.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 06/22/2011 12:35 PM, Ian Campbell wrote: > On Sun, 2011-06-19 at 15:44 +0300, Avi Kivity wrote: > > On 06/16/2011 06:50 AM, Zachary Amsden wrote: > > > The 128-bit multiply in pvclock.h was missing an output constraint for > > > EDX which caused a register corruption to appear. > > Was there any particular symptom associated with corruption at that > particular point or just general badness? > > > Thanks to Ulrich > > > for diagnosing the EDX corruption and Avi for providing this fix > > > (which now I am sending back to you Avi..) > > > > Applied and queued, thanks. > > Seems like a stable candidate also? Yes. I see it's merged; Marcelo, can you backport it? -- error compiling committee.c: too many arguments to function