From: santosh.shilimkar@ti.com (Santosh Shilimkar) Date: Fri, 24 Jun 2011 05:55:36 +0530 Subject: [PATCH] OMAP3: PM: remove get_*_restore_pointer functions, directly use entry points In-Reply-To: <1308874574-30663-1-git-send-email-khilman@ti.com> References: <1308874574-30663-1-git-send-email-khilman@ti.com> Message-ID: <4E03D980.9000705@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 6/24/2011 5:46 AM, Kevin Hilman wrote: > Upon return from off-mode, the ROM code jumps to a restore function > saved in the scratchpad. Based on SoC revision or errata, this > restore entry point is different. Current code uses some helper > functions in sleep34xx.S (get_*_restore_pointer) to get the restore > function entry point. > > When returning from off-mode, this code is executed from SDRAM, so > there's no reason to use these helper functions when using the SDRAM > entry points directly would work just fine. > > This patch uses ENTRY/ENDPROC to create "real" entry points for these > functions, and uses those values directly when writing the scratchpad. > > Tested all three entry points > - restore_es3: 3430/n900 > - restore_3630: 3630/Zoom3 > - restore: 3530/Overo > > Suggested-by: Russell King > Cc: Jean Pihet > Signed-off-by: Kevin Hilman > --- This is a nice change. In general now omap3 suspend code is looking much cleaner and after Jean's DDR patch, it would be even better. For this patch, my ack if you need one Acked-by: Santosh Shilimkar