From: Jan Kiszka Subject: [PATCH] KVM: x86: Apply required parentheses in __check_direct_spte_mmio_pf Date: Tue, 12 Jul 2011 22:00:22 +0200 Message-ID: <4E1CA7D6.4090203@web.de> References: <4E1B4CF8.605@cn.fujitsu.com> <4E1B5018.7070008@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Xiao Guangrong , LKML , KVM To: Avi Kivity , Marcelo Tosatti Return-path: In-Reply-To: <4E1B5018.7070008@cn.fujitsu.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org From: Jan Kiszka Comparison takes precedence over bitwise &, but the latter needs to be evaluated first here. Signed-off-by: Jan Kiszka --- Avi, how's your 32-bit buildbot? arch/x86/kvm/mmu.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c index d3d188e..9335e1b 100644 --- a/arch/x86/kvm/mmu.c +++ b/arch/x86/kvm/mmu.c @@ -448,7 +448,7 @@ static bool __check_direct_spte_mmio_pf(u64 spte) /* It is valid if the spte is being zapped. */ if (sspte.spte_low == 0ull && - sspte.spte_high & high_mmio_mask == high_mmio_mask) + (sspte.spte_high & high_mmio_mask) == high_mmio_mask) return true; return false;