From: stany MARCEL Date: Mon, 05 Sep 2011 15:53:35 +0200 Subject: [U-Boot] NULL base_name for hwaddr env lookup Message-ID: <4E64D45F.5000308@novasys-ingenierie.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de in net/eth.c there is this function call with test: if (eth_write_hwaddr(dev, NULL, eth_number)) If I understand correctly this test will always be true as NULL is used. I think it should be "eth" instead of NULL. Am I wrong ? If not I can submit a patch. Regards, Stany