Received: from list by lists.gnu.org with archive (Exim 4.71) id 1R91Bt-00013R-2Y for mharc-grub-devel@gnu.org; Wed, 28 Sep 2011 16:57:17 -0400 Received: from eggs.gnu.org ([140.186.70.92]:52687) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R91Bq-00011F-0W for grub-devel@gnu.org; Wed, 28 Sep 2011 16:57:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R91Bo-0003Go-SV for grub-devel@gnu.org; Wed, 28 Sep 2011 16:57:13 -0400 Received: from mail-fx0-f41.google.com ([209.85.161.41]:61647) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R91Bo-0003Gd-O4 for grub-devel@gnu.org; Wed, 28 Sep 2011 16:57:12 -0400 Received: by fxh17 with SMTP id 17so1252097fxh.0 for ; Wed, 28 Sep 2011 13:57:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; bh=oBY+I+dLa0rB/cm9ISNzCnNWfk5w6wK0we7G93wl7rY=; b=QLTePO0AKcMp0dZfEJ0lIBLz0FYshWN5HdEYHhTUbZfT1l6zbwBy3WNDHOnuvo6VVf XGO8vGqJhD9U2J31YANeTQbOo0DTkn73EwrnQ6VD3qcoybsQy5B7s1zbOwx+FBkwTgvd 1gxmZLXkRmbruv+mjLV29IBQNa3sqUUT71XwQ= Received: by 10.223.101.2 with SMTP id a2mr1671714fao.2.1317243431803; Wed, 28 Sep 2011 13:57:11 -0700 (PDT) Received: from debian.x201.phnet (67-232.197-178.cust.bluewin.ch. [178.197.232.67]) by mx.google.com with ESMTPS id w6sm36847fah.0.2011.09.28.13.57.09 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 28 Sep 2011 13:57:10 -0700 (PDT) Message-ID: <4E838A23.4080107@gmail.com> Date: Wed, 28 Sep 2011 22:57:07 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.21) Gecko/20110831 Iceowl/1.0b2 Icedove/3.1.13 MIME-Version: 1.0 To: grub-devel@gnu.org Subject: Re: [patch] Make knetbsd pass the root device References: <4E7920D0.3090401@gmail.com> <4E835FC3.90307@gmail.com> In-Reply-To: <4E835FC3.90307@gmail.com> X-Enigmail-Version: 1.1.2 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enig4103140DDA80C749BF694CC3" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 209.85.161.41 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Sep 2011 20:57:15 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig4103140DDA80C749BF694CC3 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 28.09.2011 19:56, Gr=C3=A9goire Sutre wrote: > + grub_uint64_t buf[(GRUB_DISK_SECTOR_SIZE + 7) / 8]; No need for + 7 since you know that GRUB_DISK_SECTOR_SIZE is divisible by 8. Other than this patch looks good. Go ahead (I assume that you checked that it works well with NetBSD) --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enig4103140DDA80C749BF694CC3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iF4EAREKAAYFAk6DiiMACgkQNak7dOguQgmB1wEAoFI3yiFVDEwLgN3MaDetECR8 2WNpr65k3U4jjC5mT2MA/jajiNc6RFTFHCILqaTBo0NLeW3QkEEBVtpdJhQss//x =lisx -----END PGP SIGNATURE----- --------------enig4103140DDA80C749BF694CC3--