From: ANNIE LI Subject: Re: RE: [PATCH 1/3] Introducing grant table V2 stucture Date: Thu, 10 Nov 2011 09:50:43 +0800 Message-ID: <4EBB2DF3.2050504@oracle.com> References: <4EBA35D3.3020506@oracle.com> <1320826490-29362-1-git-send-email-annie.li@oracle.com> <291EDFCB1E9E224A99088639C4762022B4543AB1BD@LONPMAILBOX01.citrite.net> <4EBAA566.80909@oracle.com> <291EDFCB1E9E224A99088639C4762022B4543AB213@LONPMAILBOX01.citrite.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <291EDFCB1E9E224A99088639C4762022B4543AB213@LONPMAILBOX01.citrite.net> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Paul Durrant Cc: "kurt.hackel@oracle.com" , "jeremy@goop.org" , "xen-devel@lists.xensource.com" , "linux-kernel@vger.kernel.org" , "konrad.wilk@oracle.com" List-Id: xen-devel@lists.xenproject.org On 2011-11-10 0:14, Paul Durrant wrote: > Annie, > > On 2011-11-9 19:11, Paul Durrant wrote: >> I see. v2 function includes mapping and arch_gnttab_map_shared, v1 function only include arch_gnttab_map_sh, right? >> This will lead to some code duplicated in two functions. > My preference would be to have duplicated calls to arch_gnttab_map_shared(). I think it's more illustrative of the difference between v1 and v2 having separate status pages. Ok, will do as you suggested, thanks. Thanks Annie