From: ANNIE LI Subject: Re: [Xen-devel] RE: [PATCH 1/3] Introducing grant table V2 stucture Date: Thu, 10 Nov 2011 09:56:56 +0800 Message-ID: <4EBB2F68.8070609@oracle.com> References: <4EBA35D3.3020506@oracle.com> <1320826490-29362-1-git-send-email-annie.li@oracle.com> <291EDFCB1E9E224A99088639C4762022B4543AB1BD@LONPMAILBOX01.citrite.net> <20111109144922.GC8410@phenom.dumpdata.com> <291EDFCB1E9E224A99088639C4762022B4543AB204@LONPMAILBOX01.citrite.net> <4EBAA3B1.8010401@oracle.com> <1320855724.955.183.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1320855724.955.183.camel@zakaz.uk.xensource.com> Sender: linux-kernel-owner@vger.kernel.org To: Ian Campbell Cc: "jeremy@goop.org" , "xen-devel@lists.xensource.com" , Konrad Rzeszutek Wilk , "kurt.hackel@oracle.com" , "linux-kernel@vger.kernel.org" , Paul Durrant List-Id: xen-devel@lists.xenproject.org On 2011-11-10 0:22, Ian Campbell wrote: > IMHO the gnttab_ bit belongs in either (or both) the struct name or the > variable names referencing the struct, rather than the fields > themselves. It should be obvious from the context that this member is > something to do with gnttab. e.g. I think gnttab_shared->addr would be > fine, as would shared->addr in the context of gnttab.c etc. Right. Thanks you all for the review, I will improve patches based on those suggestions and resend them. Thanks Annie