From: WuBo Subject: Re: [PATCH 2/3] xfstests 265: add a prealloc and reserve test Date: Wed, 16 Nov 2011 09:30:32 +0800 Message-ID: <4EC31238.3080102@cn.fujitsu.com> References: <4EB20505.7070005@cn.fujitsu.com> <4EB205CC.6010509@cn.fujitsu.com> <20111115182113.GD29840@sgi.com> <20111115190821.GA15331@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Ben Myers , linux-fsdevel@vger.kernel.org, Linux Btrfs , xfs@oss.sgi.com To: Christoph Hellwig Return-path: Received: from cn.fujitsu.com ([222.73.24.84]:54368 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1757713Ab1KPBa2 (ORCPT ); Tue, 15 Nov 2011 20:30:28 -0500 In-Reply-To: <20111115190821.GA15331@infradead.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 11/16/2011 03:08 AM, Christoph Hellwig wrote: > On Tue, Nov 15, 2011 at 12:21:13PM -0600, Ben Myers wrote: >> Hi Wu Bo, >> >> On Thu, Nov 03, 2011 at 11:09:00AM +0800, WuBo wrote: >>> This test is for preallocation test. If the disk is full, just with a prealloc >>> file has some free space that prealloc early. We need to check whether the write >>> to the free space is success or not. >>> >>> Signed-off-by: Wu Bo >> >> This test is failing for me because I don't have fallocate installed. I >> suggest the test could to be changed to check for binaries it uses, >> possibly the version of those binaries, and then not run unless the >> right ones are installed. But the best I can do right now is make a >> note of it. > > It might be even better to just use the xfs_io falloc command as we > generally expect an uptodate xfs_io for use with xfstests. Got it. thanks, wubo > > -- > To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >