From: Mohammed Shafi Shajakhan Date: Thu, 24 Nov 2011 11:37:33 +0530 Subject: [ath9k-devel] [PATCH 16/18] ath9k: make ath_reset non-static In-Reply-To: <4ECD1224.3070900@openwrt.org> References: <1321978965-21684-1-git-send-email-mohammed@qca.qualcomm.com> <1321978965-21684-17-git-send-email-mohammed@qca.qualcomm.com> <4ECD032F.4040009@openwrt.org> <4ECD0ECC.2060101@qca.qualcomm.com> <4ECD1224.3070900@openwrt.org> Message-ID: <4ECDDF25.6030900@qca.qualcomm.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ath9k-devel@lists.ath9k.org On Wednesday 23 November 2011 09:02 PM, Felix Fietkau wrote: > Doing reset from tasklet context created several nasty stability issues > that were hard to track down, and the potential gain from doing reset > 'immediately' that way is purely theoretical. Resets should be rare in > normal operation, as they're also expensive. > The main problem when running reset from a tasklet is that there is no > way of gracefully shutting down ongoing workqueue activity, so the > result of the reset could be that the work items mess up the state right > after the reset is done. thanks, true in this case ath_reset is called from tasklet context. i will send a v2 for using queue_work. > > - Felix -- thanks, shafi