Message-ID: <4ED8D117.7080904@...1114...> Date: Fri, 02 Dec 2011 14:22:31 +0100 From: David Sommerseth MIME-Version: 1.0 References: <1322823734-17993-1-git-send-email-davids@...1347...> <4ED8C6B0.2000609@...1114...> In-Reply-To: Subject: Re: [Openvpn-devel] [PATCH] Windows does not have dirname() - reimplement a portable version List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit To: Alon Bar-Lev Cc: openvpn-devel@lists.sourceforge.net -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 02/12/11 13:45, Alon Bar-Lev wrote: > On Fri, Dec 2, 2011 at 2:38 PM, David Sommerseth > wrote: >> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 >> >> On 02/12/11 13:28, Alon Bar-Lev wrote: >>> I think the whole code should be more autoconf depended. Autoconf >>> can detect if POSIX version is available and if not, code can >>> provide alternative. No need for the openvpn_ functions and >>> wrappers. >> >> Fair enough statement, but we have a python oriented build >> environment on Windows too, which will not be so easy to tackle in >> this regards. This environment is required by OpenVPN Technologies >> for their internal build farms (most likely for the OpenVPN Access >> Server product). >> > > It is not matter if you use python for Windows, as you create > config-msvc.h with all constants that autoconf would have found. Fair enough. I'll give that a poke and come up with new patches. kind regards, David Sommerseth -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk7Y0RUACgkQDC186MBRfrqiJgCfcpObXpcbhHzhgMVYvqMbwdo7 ExoAn3W3cB8zU4rQtl7DV1DdK2XjRXO7 =n594 -----END PGP SIGNATURE-----