From: Jan Kiszka Subject: Re: [RFC][PATCH 14/16] kvm: x86: Add user space part for in-kernel i8259 Date: Sun, 04 Dec 2011 14:51:24 +0100 Message-ID: <4EDB7ADC.50906@web.de> References: <4EDB762C.7090909@redhat.com> <4EDB78DE.6000109@web.de> <4EDB7A74.4060804@redhat.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigDD70987995387F20150792CE" Cc: Anthony Liguori , kvm@vger.kernel.org, "Michael S. Tsirkin" , Marcelo Tosatti , qemu-devel , Blue Swirl To: Avi Kivity Return-path: In-Reply-To: <4EDB7A74.4060804@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org List-Id: kvm.vger.kernel.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigDD70987995387F20150792CE Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 2011-12-04 14:49, Avi Kivity wrote: > On 12/04/2011 03:42 PM, Jan Kiszka wrote: >> On 2011-12-04 14:31, Avi Kivity wrote: >>> On 12/03/2011 01:17 PM, Jan Kiszka wrote: >>>> From: Jan Kiszka >>>> >>>> Introduce the alternative 'kvm-i8259' device model that exploits KVM= >>>> in-kernel acceleration. >>>> >>>> The PIIX3 initialization code is furthermore extended by KVM specifi= c >>>> IRQ route setup. Moreover, GSI injection differs in KVM mode from th= e >>>> user space model. As we can dispatch ISA-range IRQs to both IOAPIC a= nd >>>> PIC inside the kernel, we do not need to inject them separately. Thi= s is >>>> reflected by a KVM-specific GSI handler. >>>> >>>> + >>>> +qemu_irq *kvm_i8259_init(void) >>>> +{ >>>> + ISADevice *dev; >>>> + >>>> + dev =3D isa_create("kvm-i8259"); >>>> >>> >>> Same issue. Is this a different device, or an different implementati= on >>> of the same device? >> >> They are theoretically the same from guest perspective (therefore you >> can migrate between machines that differ in this). >=20 > But the name becomes part of the save/restore ABI, so you can't. Nope, the vmstate names are identical. That would ruin migration otherwise. It's just the output of info qtree & co. that changes. Jan --------------enigDD70987995387F20150792CE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk7betwACgkQitSsb3rl5xQ/AACg0+taWaGIfrHUmWRRfTFZ3Tox /noAniUIN8Sh6CFNdteTDCiat1MmLTUZ =igg2 -----END PGP SIGNATURE----- --------------enigDD70987995387F20150792CE--