From: ANNIE LI Subject: Re: [PATCH 1/2] xen/granttable: Support sub-page grants Date: Wed, 07 Dec 2011 18:50:32 +0800 Message-ID: <4EDF44F8.8060206@oracle.com> References: <4EDDF41E.8070200@oracle.com> <1323168999-4434-1-git-send-email-annie.li@oracle.com> <1323171726.23681.65.camel@zakaz.uk.xensource.com> <4EDEDF2E.3040204@oracle.com> <291EDFCB1E9E224A99088639C4762022B5988E542E@LONPMAILBOX01.citrite.net> <1323251849.23681.128.camel@zakaz.uk.xensource.com> <4EDF3F9B.4030407@oracle.com> <1323254036.23681.142.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1323254036.23681.142.camel@zakaz.uk.xensource.com> Sender: linux-kernel-owner@vger.kernel.org To: Ian Campbell Cc: Paul Durrant , "xen-devel@lists.xensource.com" , "linux-kernel@vger.kernel.org" , "konrad.wilk@oracle.com" , "jeremy@goop.org" , "kurt.hackel@oracle.com" List-Id: xen-devel@lists.xenproject.org > The existing convention seems to be for _ref to be a suffix, although > it's only actually used on the end_*_ref ones. > + int (*end_foreign_access_ref)(grant_ref_t, int); > + unsigned long (*end_foreign_transfer_ref)(grant_ref_t); > > Also it occurs to me that access_* sounds like something which uses a > ref rather than something which sets one up. The existing hook to setup > a normal grant is called "update_entry". Perhaps > update_{subpage,transitive}_entry? Yes, you are right. Just like the existing code: gnttab_grant_foreign_access VS gnttab_grant_foreign_access_subpage update_entry in gnttab_grant_foreign_access_ref VS update_{subpage,transitive}_entry in gnttab_grant_foreign_access_{subpage,trans}_ref Thanks Annie