From: Anthony Liguori <anthony@codemonkey.ws>
Date: Thu, 15 Dec 2011 00:10:50 +0000
Subject: Re: [Qemu-devel] [PATCH] spapr: Add support for -vga option
Message-Id: <4EE93B0A.1000703@codemonkey.ws>
List-Id: <kvm-ppc.vger.kernel.org>
References: <1323854540.7671.16.camel@pasglop> <4EE9199F.80305@codemonkey.ws>
	<1323907246.21839.29.camel@pasglop>
In-Reply-To: <1323907246.21839.29.camel@pasglop>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: David Gibson <dwg@au1.ibm.com>, Alexander Graf <agraf@suse.de>, kvm-ppc@vger.kernel.org, qemu-devel@nongnu.org

On 12/14/2011 06:00 PM, Benjamin Herrenschmidt wrote:
> On Wed, 2011-12-14 at 15:48 -0600, Anthony Liguori wrote:
>>>        /* USB */
>>>        if (usb_enabled) {
>>>
>> usb_ohci_init_pci(QLIST_FIRST(&spapr->phbs)->host_state.bus, -1);
>>> +     if (spapr_has_graphics) {
>>> +         usbdevice_create("keyboard");
>>> +         usbdevice_create("mouse");
>>
>> It is better to use usb_create() and pass it the usb bus directly as
>> this will make it easier to express this as composition down the road.
>
> How do I do that ? usb_ohci_init_pci() doesn't appear to return
> the USB bus....

Let's make it...  I'll send a patch.

Regards,

Anthony Liguori

>
> Cheers,
> Ben.
>
>
>