Received: from eggs.gnu.org ([140.186.70.92]:33063) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RobDs-0003De-CJ for qemu-devel@nongnu.org; Sat, 21 Jan 2012 08:43:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RobDq-0004XY-VS for qemu-devel@nongnu.org; Sat, 21 Jan 2012 08:43:12 -0500 Message-ID: <4F1AC0EB.3050304@web.de> Date: Sat, 21 Jan 2012 14:43:07 +0100 From: Jan Kiszka MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] [PATCH] qdev-property: Make bit property parsing stricter List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel , qemu-trivial Cc: Markus Armbruster By using strncasecmp, we allow for arbitrary characters after the "on"/"off" string. Fix this by switching to strcasecmp. Signed-off-by: Jan Kiszka --- hw/qdev-properties.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c index 02f0dae..ea3b2df 100644 --- a/hw/qdev-properties.c +++ b/hw/qdev-properties.c @@ -40,9 +40,9 @@ static void qdev_prop_cpy(DeviceState *dev, Property *props, void *src) /* Bit */ static int parse_bit(DeviceState *dev, Property *prop, const char *str) { - if (!strncasecmp(str, "on", 2)) + if (!strcasecmp(str, "on")) bit_prop_set(dev, prop, true); - else if (!strncasecmp(str, "off", 3)) + else if (!strcasecmp(str, "off")) bit_prop_set(dev, prop, false); else return -EINVAL; -- 1.7.3.4