From: tanmay.upadhyay@einfochips.com (Tanmay Upadhyay) Date: Mon, 23 Jan 2012 16:45:23 -0600 Subject: [PATCH 2/4] ARM: pxa168: Add SDHCI support In-Reply-To: References: <1325166236-18650-1-git-send-email-tanmay.upadhyay@einfochips.com> Message-ID: <4F1DE303.2020203@einfochips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thursday 29 December 2011 06:36 PM, Haojian Zhuang wrote: > On Thu, Dec 29, 2011 at 9:43 PM, Tanmay Upadhyay > wrote: >> v2 - clock register for SDHCI are not common across all MMP SoCs. >> So, move PXA168 implementation to pxa168.c >> >> v3 - sdhci-pxav1 driver code is merged with sdhci-pxav2. So, change >> the device name accordingly >> - start sdhci device numbering from 1 as other PXA168 devices >> does that >> >> v4 - Use different names for SD clock registers for PXA168 instead >> of redefining them in pxa168.c. Suggested by Haojian Zhuang >> >> v5 - Have two different clock enable functions for clock block 1& 2 >> & don't change indentation in regs-apmu.h as suggested by Haojian >> Zhuang >> - Use device name while adding clock as suggested by Russell King >> >> Signed-off-by: Tanmay Upadhyay >> Reviewed-by: Philip Rakity >> --- > Acked-by: Haojian Zhuang Hi Eric, Jason, Does this look good to you? Thanks, Tanmay