Message-ID: <4F23D967.1020704@web.de>
Date: Sat, 28 Jan 2012 12:17:59 +0100
From: Jan Kiszka <jan.kiszka@web.de>
MIME-Version: 1.0
References: <4F232832.8060907@web.de>
In-Reply-To: <4F232832.8060907@web.de>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="------------enig98E1BE30CED1D3210DA26755"
Subject: Re: [Qemu-devel] [PATCH] sdl: Do not grab mouse on mode switch
	while in background
To: qemu-devel <qemu-devel@nongnu.org>, qemu-trivial <qemu-trivial@nongnu.org>
Cc: Erik Rull <erik.rull@rdsoftware.de>

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig98E1BE30CED1D3210DA26755
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On 2012-01-27 23:41, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
>=20
> When the mouse mode changes to absolute while the SDL windows is not in=

> focus, refrain from grabbing the input. It would steal from some other
> window.

I'll send out a SDL series with fixes and will include this. So forget
about it for trivial.

Thanks,
Jan

>=20
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>=20
> I bet this makes no difference for your problem, Erik, but I came
> across this while trying to reproduce the issue.
>=20
>  ui/sdl.c |   30 ++++++++++++++++--------------
>  1 files changed, 16 insertions(+), 14 deletions(-)
>=20
> diff --git a/ui/sdl.c b/ui/sdl.c
> index 8cafc44..384276d 100644
> --- a/ui/sdl.c
> +++ b/ui/sdl.c
> @@ -483,12 +483,27 @@ static void sdl_grab_end(void)
>      sdl_update_caption();
>  }
> =20
> +static void absolute_mouse_grab(void)
> +{
> +    int mouse_x, mouse_y;
> +
> +    if (SDL_GetAppState() & SDL_APPINPUTFOCUS) {
> +        SDL_GetMouseState(&mouse_x, &mouse_y);
> +        if (mouse_x > 0 && mouse_x < real_screen->w - 1 &&
> +            mouse_y > 0 && mouse_y < real_screen->h - 1) {
> +            sdl_grab_start();
> +        }
> +    }
> +}
> +
>  static void sdl_mouse_mode_change(Notifier *notify, void *data)
>  {
>      if (kbd_mouse_is_absolute()) {
>          if (!absolute_enabled) {
> -            sdl_grab_start();
>              absolute_enabled =3D 1;
> +            if (is_graphic_console()) {
> +                absolute_mouse_grab();
> +            }
>          }
>      } else if (absolute_enabled) {
>          if (!gui_fullscreen) {
> @@ -571,19 +586,6 @@ static void toggle_full_screen(DisplayState *ds)
>      vga_hw_update();
>  }
> =20
> -static void absolute_mouse_grab(void)
> -{
> -    int mouse_x, mouse_y;
> -
> -    if (SDL_GetAppState() & SDL_APPINPUTFOCUS) {
> -        SDL_GetMouseState(&mouse_x, &mouse_y);
> -        if (mouse_x > 0 && mouse_x < real_screen->w - 1 &&
> -            mouse_y > 0 && mouse_y < real_screen->h - 1) {
> -            sdl_grab_start();
> -        }
> -    }
> -}
> -
>  static void handle_keydown(DisplayState *ds, SDL_Event *ev)
>  {
>      int mod_state;


--------------enig98E1BE30CED1D3210DA26755
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.16 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk8j2WcACgkQitSsb3rl5xRmmgCgid8E2IMj7x1YSSa0nTtTPcrj
2TMAoIty+6y7RhQzpc2FkV5gwaDdqy/7
=ht0z
-----END PGP SIGNATURE-----

--------------enig98E1BE30CED1D3210DA26755--