From: Jiri Slaby Subject: Re: [PATCH] sysfs: Update the name hash when renaming sysfs entries Date: Tue, 31 Jan 2012 15:41:36 +0100 Message-ID: <4F27FDA0.6090806@suse.cz> References: <4F27120A.4040106@suse.cz> <4F27C54F.1010107@suse.cz> <4F27C9D4.3040105@suse.cz> <4F27CDBC.5020201@suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Greg KH , Greg Kroah-Hartman , LKML , ML netdev , Kay Sievers To: "Eric W. Biederman" Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 01/31/2012 03:40 PM, Eric W. Biederman wrote: > > This fixes a bug introduced with sysfs name hashes where renaming a > network device appears to succeed but silently makes the sysfs files for > that network device inaccessible. > > In at least one configuration this bug has stopped networking from > coming up during boot. > > Signed-off-by: Eric W. Biederman It works for me. Thanks. Tested-by: Jiri Slaby > --- > fs/sysfs/dir.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/fs/sysfs/dir.c b/fs/sysfs/dir.c > index ea64d01..dd3779c 100644 > --- a/fs/sysfs/dir.c > +++ b/fs/sysfs/dir.c > @@ -872,6 +872,7 @@ int sysfs_rename(struct sysfs_dirent *sd, > > dup_name = sd->s_name; > sd->s_name = new_name; > + sd->s_hash = sysfs_name_hash(sd->s_ns, sd->s_name); > } > > /* Move to the appropriate place in the appropriate directories rbtree. */ -- js suse labs