Received: from eggs.gnu.org ([140.186.70.92]:49098) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rtgy2-0004HB-8K for qemu-devel@nongnu.org; Sat, 04 Feb 2012 09:51:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rtgy0-0008L9-2F for qemu-devel@nongnu.org; Sat, 04 Feb 2012 09:51:54 -0500 Message-ID: <4F2D45FF.9070204@web.de> Date: Sat, 04 Feb 2012 15:51:43 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <4F2BCCBD.8050009@siemens.com> <4F2D2352.80204@web.de> In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig818B3DA45E29F5EED18FAF63" Subject: Re: [Qemu-devel] [PATCH] memory-region: Report if region is read-only on info mtree List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: qemu-trivial , qemu-devel , Avi Kivity This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig818B3DA45E29F5EED18FAF63 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 2012-02-04 13:32, Blue Swirl wrote: > On Sat, Feb 4, 2012 at 12:23, Jan Kiszka wrote: >> On 2012-02-04 13:12, Blue Swirl wrote: >>> On Fri, Feb 3, 2012 at 12:02, Jan Kiszka wro= te: >>>> Helpful to understand guest configurations of things like the i440FX= 's >>>> PAM. >>>> >>>> Signed-off-by: Jan Kiszka >>>> --- >>>> memory.c | 6 ++++-- >>>> 1 files changed, 4 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/memory.c b/memory.c >>>> index ee4c98a..ea4adda 100644 >>>> --- a/memory.c >>>> +++ b/memory.c >>>> @@ -1608,23 +1608,25 @@ static void mtree_print_mr(fprintf_function = mon_printf, void *f, >>>> ml->printed =3D false; >>>> QTAILQ_INSERT_TAIL(alias_print_queue, ml, queue); >>>> } >>>> - mon_printf(f, TARGET_FMT_plx "-" TARGET_FMT_plx " (prio %d)= : alias %s @%s " >>>> + mon_printf(f, TARGET_FMT_plx "-" TARGET_FMT_plx " (prio %d,= %s): alias %s @%s " >>>> TARGET_FMT_plx "-" TARGET_FMT_plx "\n", >>>> base + mr->addr, >>>> base + mr->addr >>>> + (target_phys_addr_t)int128_get64(mr->size) - 1,= >>>> mr->priority, >>>> + mr->readonly ? "RO" : "RW", >>> >>> I think the reserved regions which are unreadable and unwritable >>> should be shown as well. Then the output should be a combination of >>> 'R', 'W' or neither ('-'). >> >> Reserved regions are in the hand of some other device model (so far on= ly >> the KVM kernel). That says nothing about their R/W property. If we eve= r >> have a reserved region that is not writable, the owner could still set= >> the corresponding flag for documentation purposes. >=20 > OK. But it's also possible for a region to have readable =3D=3D false > while readonly =3D=3D false, which would imply 'WO' or '-W'. That also > supports separate 'R', 'W' and '-' flags. Yep, I encoded the ROM device state as well. And this revealed a regression of the memory region conversion of the cfi02. Gave up counting how often I fixed this type of bug in the flash code. Jan --------------enig818B3DA45E29F5EED18FAF63 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk8tRgEACgkQitSsb3rl5xQNLACcD28Ijx7U6x3OJzNW7VFyvFlK ePwAn09vjMOuyNGp3Zd2T8QO+D64mckf =VF1L -----END PGP SIGNATURE----- --------------enig818B3DA45E29F5EED18FAF63--