From: Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: [PATCHv3 1/4] pci_bridge: user-friendly default
 bus name
Date: Wed, 22 Feb 2012 12:59:46 -0600
Message-ID: <4F453B22.1000200@codemonkey.ws>
References: <cover.1329778092.git.mst@redhat.com>
	<57300b99e60a939c6b9c5c27066a4970f167dfc0.1329778092.git.mst@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Kevin Wolf <kwolf@redhat.com>, kvm@vger.kernel.org, qemu-devel@nongnu.org,
	Isaku Yamahata <yamahata@valinux.co.jp>, kraxel@redhat.com,
	Avi Kivity <avi@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Return-path: <qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org>
In-Reply-To: <57300b99e60a939c6b9c5c27066a4970f167dfc0.1329778092.git.mst@redhat.com>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org
Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org
List-Id: kvm.vger.kernel.org

On 02/20/2012 04:52 PM, Michael S. Tsirkin wrote:
> For a pci bridge device, if we don't override
> the name with custom code, the bus will be addressed as
> <id>.0, where id is the id specified by the user.
>
> Since PCI Bridge devices have a single bus each, we don't need
> the index: address the bus using the parent device name.
> This is better since this way users don't care about
> our internal bus/device distinctions.
>
> As far as I could see, we only have built-in
> bridges at this point which always override the
> name. So this change will only affect ioh3420.c.
>
> Signed-off-by: Michael S. Tsirkin<mst@redhat.com>

Reviewed-by: Anthony Liguori <aliguori@us.ibm.com>

I think we're safe here from a compatibility perspective.

Regards,

Anthony Liguori

> ---
>   hw/pci_bridge.c |   10 ++++++++++
>   1 files changed, 10 insertions(+), 0 deletions(-)
>
> diff --git a/hw/pci_bridge.c b/hw/pci_bridge.c
> index fea3873..eeee8a6 100644
> --- a/hw/pci_bridge.c
> +++ b/hw/pci_bridge.c
> @@ -314,6 +314,16 @@ int pci_bridge_initfn(PCIDevice *dev)
>       pci_set_word(dev->config + PCI_SEC_STATUS,
>                    PCI_STATUS_66MHZ | PCI_STATUS_FAST_BACK);
>
> +    /*
> +     * If we don't specify the name, the bus will be addressed as<id>.0, where
> +     * id is the device id.
> +     * Since PCI Bridge devices have a single bus each, we don't need the index:
> +     * let users address the bus using the device name.
> +     */
> +    if (!br->bus_name&&  dev->qdev.id&&  *dev->qdev.id) {
> +	    br->bus_name = dev->qdev.id;
> +    }
> +
>       qbus_create_inplace(&sec_bus->qbus,&pci_bus_info,&dev->qdev,
>                           br->bus_name);
>       sec_bus->parent_dev = dev;