From: Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [PATCHv3 0/4] standard pci bridge device
Date: Mon, 27 Feb 2012 15:38:23 +0100
Message-ID: <4F4B955F.7080800@redhat.com>
References: <cover.1329778092.git.mst@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org,
	Wen Congyang <wency@cn.fujitsu.com>,
	Avi Kivity <avi@redhat.com>, Kevin Wolf <kwolf@redhat.com>,
	Anthony Liguori <anthony@codemonkey.ws>,
	Isaku Yamahata <yamahata@valinux.co.jp>, berrange@redhat.com
To: "Michael S. Tsirkin" <mst@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:47757 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753180Ab2B0Oij (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 27 Feb 2012 09:38:39 -0500
In-Reply-To: <cover.1329778092.git.mst@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 02/20/12 23:52, Michael S. Tsirkin wrote:
> Here's a new version of the patch.
> 
> TODOs:
> - windows guest testing
> 
> Changes from v2:
> - added slot id capability
> - migration support
> - misc fixes
> - fix checkpatch errors

64bit prefetch memory window works now:

00:10.0 PCI bridge: Red Hat, Inc. Device 0001 (prog-if 00 [Normal decode])
        Physical Slot: 16
        Flags: bus master, 66MHz, fast devsel, latency 0
        Memory at f5126000 (32-bit, non-prefetchable) [size=256]
        Bus: primary=00, secondary=01, subordinate=01, sec-latency=0
        Memory behind bridge: f5000000-f50fffff
        Prefetchable memory behind bridge: 00000000f8000000-00000000fbffffff
        Capabilities: [48] Slot ID: 0 slots, First+, chassis 01
        Capabilities: [40] Hot-plug capable
        Kernel modules: shpchp

Looks good to me, did only light testing though.

cheers,
  Gerd