Message-ID: <4F4C6C14.9030303@...1550...> Date: Tue, 28 Feb 2012 09:54:28 +0400 From: Igor Novgorodov MIME-Version: 1.0 References: <4F4BE238.502@...1550...> In-Reply-To: Subject: Re: [Openvpn-devel] [PATCH 02/02] Remove calls to OpenSSL when building with --disable-ssl List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit To: Alon Bar-Lev Cc: openvpn-devel@lists.sourceforge.net Then maybe we should move these calls to crypto_openssl.c into crypto_init_lib() function to make crypto.c library-independent? And why OpenSSL_add_all_algorithms() and stuff is called only when USE_SSL is not defined? And if these calls are for 0.9.8, maybe add a check for OpenSSL version? On 28.02.2012 0:10, Alon Bar-Lev wrote: > These are needed for 0.9.8 as far as I remember. > On Mon, Feb 27, 2012 at 10:06 PM, Igor Novgorodov wrote: >> The attached patch removes deprecated(?) calls to OpenSSL functions from >> crypro.c, >> which are called when USE_SSL is not defined. >> >> I'm not so deep into OpenVPN, so maybe these functions are needed, but i >> thought that all crypto-lib >> dependent functions should be moved to the corresponding crypto_LIB.c files. >> >> If they are needed, we should #ifdef them, so that PolarSSL-based build >> won't break on it. >> >> ------------------------------------------------------------------------------ >> Try before you buy = See our experts in action! >> The most comprehensive online learning library for Microsoft developers >> is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, >> Metro Style Apps, more. Free future releases when you subscribe now! >> http://p.sf.net/sfu/learndevnow-dev2 >> _______________________________________________ >> Openvpn-devel mailing list >> Openvpn-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/openvpn-devel >>