Return-Path: Message-ID: <4F777316.9090406@gmx.de> Date: Sat, 31 Mar 2012 21:11:50 +0000 From: Florian Tobias Schandinat MIME-Version: 1.0 To: Alan Cox CC: Greg KH , linux-kernel@vger.kernel.org, stable@vger.kernel.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, Wang YanQing Subject: Re: [ 086/149] video:uvesafb: Fix oops that uvesafb try to execute NX-protected page References: <20120330194853.145065448@linuxfoundation.org> <4F76260C.7080005@gmx.de> <20120331180317.GA10792@kroah.com> <20120331213738.57a9649d@pyramind.ukuu.org.uk> In-Reply-To: <20120331213738.57a9649d@pyramind.ukuu.org.uk> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: On 03/31/2012 08:37 PM, Alan Cox wrote: > On Sat, 31 Mar 2012 11:03:17 -0700 > Greg KH wrote: > >> On Fri, Mar 30, 2012 at 09:30:52PM +0000, Florian Tobias Schandinat wrote: >>> Hi Greg, >>> >>> On 03/30/2012 07:49 PM, Greg KH wrote: >>>> 3.2-stable review patch. If anyone has any objections, please let me know. >>> >>> the same as for 3.3: This patch would require exporting >>> 'pcibios_enabled' to not break building uvesafb as a module. As Alan did >>> not agree with this approach it is not suitable for stable as is. >> >> Oops, sorry about that, now removed, thanks for letting me know. > > Actually for the backport its probably the right thing to do - its > simple, clear and slightly ugly, but its fairly provably safe. Is there a problem with using your preferred solution "__supported_pte_mask & _PAGE_NX" here? As far as I can see it should work since 2008. Best regards, Florian Tobias Schandinat