From: Gabor Juhos Date: Sun, 15 Apr 2012 19:23:18 +0200 Subject: [ath9k-devel] [RFC 1/2] ath9k: add an extra boolean parameter to ath9k_hw_apply_txpower In-Reply-To: <4F8AA1F5.5030402@openwrt.org> References: <1334417539-6498-1-git-send-email-juhosg@openwrt.org> <4F8AA1F5.5030402@openwrt.org> Message-ID: <4F8B0406.9000901@openwrt.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ath9k-devel@lists.ath9k.org 2012.04.15. 12:24 keltez?ssel, Felix Fietkau ?rta: > On 2012-04-14 5:32 PM, Gabor Juhos wrote: >> In order to unifying regulatory limit handling >> commit ca2c68cc7bc80fc4504fb420df04cce99c9ee6ec >> (ath9k_hw: clean up tx power handling) introduced >> a new helper function 'ath9k_hw_apply_txpower', >> and the direct calls of 'ah->eep_ops->set_txpower' >> has been replaced by a call of the helper function. >> >> This caused a change in the behaviour of the >> 'ath9k_hw_set_txpowerlimit' function. The purpose >> of that function is to calculate and store the >> rate txpower table and the regulatory limit without >> touching the hardware registers. Before the commit, >> the 'test' parameter of the function was passed to >> the 'ah->eep_ops->set_txpower'. Now the calling of >> the 'set_txpower' function happens indirectly through >> 'ath9k_hw_apply_txpower', so the 'test' argument of >> the 'set_txpower' is always 'false'. >> >> This patch restores the original behaviour of >> 'ath9k_hw_set_txpowerlimit' by adding a new >> argument to 'ath9k_hw_apply_txpower.' >> >> Signed-off-by: Gabor Juhos >> Cc: Felix Fietkau > Acked-by: Felix Fietkau > Thanks, I will resend this as a regular patch. -Gabor