From: Kristof Provost Date: Tue, 17 May 2022 17:29:36 +0200 Message-ID: <4F94D259-DDA4-49B3-907B-E32BAC4653D7@...2661...> In-Reply-To: References: <20220516185621.6182-1-kprovost@...2661...> <20220516185621.6182-3-kprovost@...2661...> MIME-Version: 1.0 Subject: Re: [Openvpn-devel] [PATCH 2/4] rework do_up() for correct order of DCO operations List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Antonio Quartulli Cc: openvpn-devel On 17 May 2022, at 15:28, Antonio Quartulli wrote: > On 16/05/2022 20:56, Kristof Provost via Openvpn-devel wrote: >> From: Kristof Provost >> >> We must create the peer before we can dco_set_peer or dco_new_key. >> On the other hand, we must first process options, because those may >> change our peer id and we should create the peer with the correct id. >> >> Split up do_deferred_options() in do_deferred_options() and >> finish_options(). Call any DCO configuration operations (i.e. >> dco_set_peer()/dco_new_key()) after we've created the peer (i.e. >> dco_new_peer()). >> >> Signed-off-by: Kristof Provost > > I am including this patch in the dco branch as well. > > Please note that this change has been reworked a little bit. > Thanks! Kristof