From: Ben Greear <greearb@candelatech.com>
Date: Tue, 08 May 2012 08:06:59 -0700
Subject: [ath9k-devel] [PATCH] ath9k: Support ethtool getstats api.
In-Reply-To: <87zk9j85ue.fsf@purkki.adurom.net>
References: <1336411437-16653-1-git-send-email-greearb@candelatech.com>
	<1336412033.20924.6.camel@joe2Laptop>
	<4FA80D02.404@candelatech.com> <87zk9j85ue.fsf@purkki.adurom.net>
Message-ID: <4FA93693.40105@candelatech.com>
List-Id: <ath9k-devel.lists.ath9k.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: ath9k-devel@lists.ath9k.org

On 05/08/2012 12:55 AM, Kalle Valo wrote:
> Ben Greear<greearb@candelatech.com>  writes:
>
>> No, there is a check later that does a BUG_ON if our
>> we have screwed up the indexing of the stats.
>
> Please, no BUG_ON() calls in wifi drivers. They just make users life
> miserable. WARN_ON() with a safe bailout is enough.

Ok, I can change that.

The reason I left it at BUG_ON before is because a mistake
here could easily be a buffer overflow, so I wanted to make
sure it was caught in development.

But, a warn-on should be sufficient.

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com