From: Bernd Schubert Subject: Re: [PATCH] bio allocation failure due to bio_get_nr_vecs() Date: Fri, 11 May 2012 16:31:25 +0200 Message-ID: <4FAD22BD.7010007@itwm.fraunhofer.de> References: <4FABF01E.7080303@itwm.fraunhofer.de> <4FAD18D4.3090102@itwm.fraunhofer.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------080007060100060203010907" Cc: "linux-fsdevel@vger.kernel.org" , linux-xfs@oss.sgi.com, sandeen@sandeen.net, Kent Overstreet , Tejun Heo , Jens Axboe To: Jeff Moyer Return-path: Received: from mailgw1.uni-kl.de ([131.246.120.220]:51684 "EHLO mailgw1.uni-kl.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756061Ab2EKObe (ORCPT ); Fri, 11 May 2012 10:31:34 -0400 Received: from itwm2.itwm.fhg.de (itwm2.itwm.fhg.de [131.246.191.3]) by mailgw1.uni-kl.de (8.14.3/8.14.3/Debian-5+lenny1) with ESMTP id q4BEVR3k028372 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NOT) for ; Fri, 11 May 2012 16:31:28 +0200 In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: This is a multi-part message in MIME format. --------------080007060100060203010907 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit On 05/11/2012 04:06 PM, Jeff Moyer wrote: > Bernd Schubert writes: > >> diff --git a/fs/bio.c b/fs/bio.c >> index e453924..84da885 100644 >> --- a/fs/bio.c >> +++ b/fs/bio.c >> @@ -505,9 +505,14 @@ EXPORT_SYMBOL(bio_clone); >> int bio_get_nr_vecs(struct block_device *bdev) >> { >> struct request_queue *q = bdev_get_queue(bdev); >> - return min_t(unsigned, >> + int nr_pages; > > Looks like a corrupt patch. What do you actually mean? Issue by thunderbird? I just saved the mail in my sent folder and it looks? Just to be sure, patch attached. Thanks, Bernd --------------080007060100060203010907 Content-Type: text/x-patch; name="fix-bio-nrvec.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="fix-bio-nrvec.patch" bio: bio_get_nr_vecs() must not return more than BIO_MAX_PAGES From: Bernd Schubert The number of bio_get_nr_vecs() is passed down via bio_alloc() to bvec_alloc_bs(), which fails the bio allocation if nr_iovecs > BIO_MAX_PAGES. For the underlying caller this causes an unexpected bio allocation failure. Limiting to queue_max_segments() is not sufficiet, as max_segments also might be very large. bvec_alloc_bs(gfp_mask, nr_iovecs, ) => NULL when nr_iovecs > BIO_MAX_PAGES bio_alloc_bioset(gfp_mask, nr_iovecs, ...) bio_alloc(GFP_NOIO, nvecs) xfs_alloc_ioend_bio() Signed-off-by: Bernd Schubert --- fs/bio.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/fs/bio.c b/fs/bio.c index e453924..84da885 100644 --- a/fs/bio.c +++ b/fs/bio.c @@ -505,9 +505,14 @@ EXPORT_SYMBOL(bio_clone); int bio_get_nr_vecs(struct block_device *bdev) { struct request_queue *q = bdev_get_queue(bdev); - return min_t(unsigned, + int nr_pages; + + nr_pages = min_t(unsigned, queue_max_segments(q), queue_max_sectors(q) / (PAGE_SIZE >> 9) + 1); + + return min_t(unsigned, nr_pages, BIO_MAX_PAGES); + } EXPORT_SYMBOL(bio_get_nr_vecs); --------------080007060100060203010907--