From: Bernd Schubert Subject: Re: [PATCH] bio allocation failure due to bio_get_nr_vecs() Date: Fri, 11 May 2012 16:44:03 +0200 Message-ID: <4FAD25B3.3050802@itwm.fraunhofer.de> References: <4FABF01E.7080303@itwm.fraunhofer.de> <4FAD18D4.3090102@itwm.fraunhofer.de> <4FAD23F7.2080605@kernel.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "linux-fsdevel@vger.kernel.org" , linux-xfs@oss.sgi.com, sandeen@sandeen.net, Kent Overstreet , Tejun Heo To: Jens Axboe Return-path: Received: from mailgw1.uni-kl.de ([131.246.120.220]:49903 "EHLO mailgw1.uni-kl.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760208Ab2EKOoH (ORCPT ); Fri, 11 May 2012 10:44:07 -0400 Received: from itwm2.itwm.fhg.de (itwm2.itwm.fhg.de [131.246.191.3]) by mailgw1.uni-kl.de (8.14.3/8.14.3/Debian-5+lenny1) with ESMTP id q4BEi5Qh000629 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NOT) for ; Fri, 11 May 2012 16:44:05 +0200 In-Reply-To: <4FAD23F7.2080605@kernel.dk> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 05/11/2012 04:36 PM, Jens Axboe wrote: > On 05/11/2012 03:49 PM, Bernd Schubert wrote: >> The number of bio_get_nr_vecs() is passed down via bio_alloc() to >> bvec_alloc_bs(), which fails the bio allocation if >> nr_iovecs> BIO_MAX_PAGES. For the underlying caller this causes an >> unexpected bio allocation failure. >> Limiting to queue_max_segments() is not sufficient, as max_segments >> also might be very large. >> >> bvec_alloc_bs(gfp_mask, nr_iovecs, ) => NULL when nr_iovecs> BIO_MAX_PAGES >> bio_alloc_bioset(gfp_mask, nr_iovecs, ...) >> bio_alloc(GFP_NOIO, nvecs) >> xfs_alloc_ioend_bio() > > Thanks, looks sane. Applied. > Great, thanks! Should we CC linux-stable for commit 5abebfdd02450fa1349daacf242e70b3736581e3 and this one, as I got a hard kernel panic? Thanks, Bernd