From: KAMEZAWA Hiroyuki Subject: Re: [PATCH v3 6/6] remove __must_check for res_counter_charge_nofail() Date: Tue, 15 May 2012 09:02:28 +0900 Message-ID: <4FB19D14.7080208@jp.fujitsu.com> References: <4FACDED0.3020400@jp.fujitsu.com> <4FACE184.6020307@jp.fujitsu.com> <20120514200925.GH2366@google.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20120514200925.GH2366-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Tejun Heo Cc: "linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org" , "cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Michal Hocko , Johannes Weiner , Frederic Weisbecker , Han Ying , Glauber Costa , "Aneesh Kumar K.V" , Andrew Morton , Hiroyuki Kamezawa , Linux Kernel (2012/05/15 5:09), Tejun Heo wrote: > On Fri, May 11, 2012 at 06:53:08PM +0900, KAMEZAWA Hiroyuki wrote: >> I picked this up from Costa's slub memcg series. For fixing added warning >> by patch 4. >> == >> From: Glauber Costa >> Subject: [PATCH 6/6] remove __must_check for res_counter_charge_nofail() >> >> Since we will succeed with the allocation no matter what, there >> isn't the need to use __must_check with it. It can very well >> be optional. >> >> Signed-off-by: Glauber Costa >> Signed-off-by: KAMEZAWA Hiroyuki > > For 3-6, > > Reviewed-by: Tejun Heo > > Thanks a lot for doing this. This doesn't solve all the failure paths > tho. ie. what about -EINTR failures from lock contention? > pre_destroy() would probably need delay and retry logic with > WARN_ON_ONCE() on !-EINTR failures. > Yes, I'll do more work. I tend to split series, sorry. Thanks, -Kame