Return-Path: Message-ID: <4FC633A7.1050406@zytor.com> Date: Wed, 30 May 2012 07:50:15 -0700 From: "H. Peter Anvin" MIME-Version: 1.0 To: Konrad Rzeszutek Wilk CC: Andre Przywara , mingo@elte.hu, tglx@linutronix.de, jeremy@goop.org, xen-devel@lists.xensource.com, stable@vger.kernel.org#3.4+, linux-kernel@vger.kernel.org Subject: Re: [Xen-devel] [PATCH] x86/amd: fix crash as Xen Dom0 on AMD Trinity systems References: <1338383402-3838-1-git-send-email-andre.przywara@amd.com> <20120530143937.GF3207@phenom.dumpdata.com> In-Reply-To: <20120530143937.GF3207@phenom.dumpdata.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: On 05/30/2012 07:39 AM, Konrad Rzeszutek Wilk wrote: > On Wed, May 30, 2012 at 03:10:02PM +0200, Andre Przywara wrote: >> Because we are behind a family check before tweaking the topology >> bit, we can use the standard rd/wrmsr variants for the CPUID feature >> register. >> This fixes a crash when using the kernel as a Xen Dom0 on affected >> Trinity systems. The wrmsrl_amd_safe is not properly paravirtualized >> yet (this will be fixed in another patch). > > So with a rdmsrl_amd_safe and wrmsrl_amd_safe being implemented in > the pv_cpu_ops - would this patch even be neccessary? > That is still bogus; a better thing would be to implement the _regs interface. Even better would be to trap and emulate rdmsr/wrmsr! -hpa -- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf.