From: Felix Fietkau Date: Wed, 27 Jun 2012 16:48:35 +0200 Subject: [ath9k-devel] [PATCH 2/2] ath9k: Fix signedness in a MCI debug message In-Reply-To: <1340807427-5774-2-git-send-email-mohammed@qca.qualcomm.com> References: <1340807427-5774-1-git-send-email-mohammed@qca.qualcomm.com> <1340807427-5774-2-git-send-email-mohammed@qca.qualcomm.com> Message-ID: <4FEB1D43.7080706@openwrt.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ath9k-devel@lists.ath9k.org On 2012-06-27 4:30 PM, Mohammed Shafi Shajakhan wrote: > From: Mohammed Shafi Shajakhan > > seems i got a message like this > ath: phy0: BT_Status_Update: is_link=0, linkId=2, > state=1, SEQ=-2085766476 initially. > > Signed-off-by: Mohammed Shafi Shajakhan > --- > drivers/net/wireless/ath/ath9k/mci.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath9k/mci.c b/drivers/net/wireless/ath/ath9k/mci.c > index c40e568..64cc782 100644 > --- a/drivers/net/wireless/ath/ath9k/mci.c > +++ b/drivers/net/wireless/ath/ath9k/mci.c > @@ -348,7 +348,7 @@ static void ath_mci_msg(struct ath_softc *sc, u8 opcode, u8 *rx_payload) > > seq_num = *((u32 *)(rx_payload + 12)); > ath_dbg(common, MCI, > - "BT_Status_Update: is_link=%d, linkId=%d, state=%d, SEQ=%d\n", > + "BT_Status_Update: is_link=%d, linkId=%d, state=%d, SEQ=%u\n", > profile_status.is_link, profile_status.conn_handle, > profile_status.is_critical, seq_num); What about endian here? Also, wouldn't it be better to have a struct for the rx payload data with proper endian annotation instead of using the weird way of dereferencing the rx_payload pointer? - Felix