From: Fernando Luis Vazquez Cao Subject: Re: [PATCH] NTFS: remove references to long gone super operations Date: Wed, 04 Jul 2012 20:42:34 +0900 Message-ID: <4FF42C2A.2080004@lab.ntt.co.jp> References: <4FF4125F.8070604@lab.ntt.co.jp> <20120704111414.GA14053@infradead.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------010704060305090402090002" Cc: Anton Altaparmakov , linux-ntfs-dev@lists.sourceforge.net, linux-fsdevel@vger.kernel.org To: Christoph Hellwig Return-path: Received: from tama500.ecl.ntt.co.jp ([129.60.39.148]:45173 "EHLO tama500.ecl.ntt.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751226Ab2GDLm7 (ORCPT ); Wed, 4 Jul 2012 07:42:59 -0400 In-Reply-To: <20120704111414.GA14053@infradead.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: This is a multi-part message in MIME format. --------------010704060305090402090002 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit On 2012/07/04 20:14, Christoph Hellwig wrote: > On Wed, Jul 04, 2012 at 06:52:31PM +0900, Fernando Luis Vazquez Cao wrote: >> Subject: NTFS: remove references to long gone super operations >> >> From: Fernando Luis Vazquez Cao >> >> ->delete_inode(), ->write_super_lockfs(), ->unlockfs() are gone so remove >> refereces to them in the NTFS code. Noticed while cleaning up the fsfreeze >> mess. > > How about removing all the long comments about unimplemented operations? > No major filesystem does this and there's no real point either. Good point. Updated patch attached. --------------010704060305090402090002 Content-Type: text/x-patch; name="ntfs-remove-references-to-long-gone-super_operations.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename*0="ntfs-remove-references-to-long-gone-super_operations.patch" Subject: NTFS: remove references to long gone super operations and unimplemented methods From: Fernando Luis Vazquez Cao ->delete_inode(), ->write_super_lockfs(), ->unlockfs() are gone so remove refereces to them in the NTFS code. Remove unnecessary comments about unimplemented methods while at it (suggested by Christoph Hellwig). Noticed while cleaning up the fsfreeze mess. Signed-off-by: Fernando Luis Vazquez Cao --- diff -urNp linux-3.5-rc5-orig/fs/ntfs/super.c linux-3.5-rc5/fs/ntfs/super.c --- linux-3.5-rc5-orig/fs/ntfs/super.c 2012-05-21 07:29:13.000000000 +0900 +++ linux-3.5-rc5/fs/ntfs/super.c 2012-07-04 20:33:30.528946289 +0900 @@ -2660,31 +2660,14 @@ static const struct super_operations ntf .alloc_inode = ntfs_alloc_big_inode, /* VFS: Allocate new inode. */ .destroy_inode = ntfs_destroy_big_inode, /* VFS: Deallocate inode. */ #ifdef NTFS_RW - //.dirty_inode = NULL, /* VFS: Called from - // __mark_inode_dirty(). */ .write_inode = ntfs_write_inode, /* VFS: Write dirty inode to disk. */ - //.drop_inode = NULL, /* VFS: Called just after the - // inode reference count has - // been decreased to zero. - // NOTE: The inode lock is - // held. See fs/inode.c:: - // generic_drop_inode(). */ - //.delete_inode = NULL, /* VFS: Delete inode from disk. - // Called when i_count becomes - // 0 and i_nlink is also 0. */ - //.write_super = NULL, /* Flush dirty super block to - // disk. */ - //.sync_fs = NULL, /* ? */ - //.write_super_lockfs = NULL, /* ? */ - //.unlockfs = NULL, /* ? */ #endif /* NTFS_RW */ .put_super = ntfs_put_super, /* Syscall: umount. */ .statfs = ntfs_statfs, /* Syscall: statfs */ .remount_fs = ntfs_remount, /* Syscall: mount -o remount. */ .evict_inode = ntfs_evict_big_inode, /* VFS: Called when an inode is removed from memory. */ - //.umount_begin = NULL, /* Forced umount. */ .show_options = ntfs_show_options, /* Show mount options in proc. */ }; --------------010704060305090402090002--